From: Lee Jones <lee@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Dustin Howett <dustin@howett.net>, Pavel Machek <pavel@ucw.cz>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
chrome-platform@lists.linux.dev,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v2 0/5] ChromeOS Embedded Controller LED driver
Date: Thu, 13 Jun 2024 15:41:37 +0100 [thread overview]
Message-ID: <20240613144137.GG2561462@google.com> (raw)
In-Reply-To: <264dd508-93c5-48d6-ac69-27458acd29c5@t-8ch.de>
On Mon, 03 Jun 2024, Thomas Weißschuh wrote:
> On 2024-06-02 18:30:06+0000, Dustin Howett wrote:
> > On Fri, May 31, 2024 at 11:33 AM Thomas Weißschuh <linux@weissschuh.net> wrote:
> > >
> > > Add a LED driver that supports the LED devices exposed by the
> > > ChromeOS Embedded Controller.
> >
> > I've tested this out on the Framework Laptop 13, 11th gen intel core
> > and AMD Ryzen 7040 editions.
> >
> > It works fairly well! I found a couple minor issues in day-to-day use:
>
> Thanks!
>
> > - Restoring the trigger to chromeos-auto does not always put the EC
> > back in control, e.g. the side lights no longer return to reporting
> > charge status.
> > I believe this happens when you move from any trigger except "none"
> > to chromeos-auto, without first setting "none".
>
> Thanks for the report, I'll investigate that.
So am I reviewing this set or waiting for the next version?
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-06-13 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 16:33 [PATCH v2 0/5] ChromeOS Embedded Controller LED driver Thomas Weißschuh
2024-05-31 16:33 ` [PATCH v2 1/5] leds: core: Introduce led_get_color_name() function Thomas Weißschuh
2024-05-31 16:33 ` [PATCH v2 2/5] leds: multicolor: Use " Thomas Weißschuh
2024-05-31 16:33 ` [PATCH v2 3/5] leds: core: Unexport led_colors[] array Thomas Weißschuh
2024-05-31 16:33 ` [PATCH v2 4/5] leds: Add ChromeOS EC driver Thomas Weißschuh
2024-05-31 16:33 ` [PATCH v2 5/5] mfd: cros_ec: Register LED subdevice Thomas Weißschuh
2024-06-02 23:30 ` [PATCH v2 0/5] ChromeOS Embedded Controller LED driver Dustin Howett
2024-06-03 20:56 ` Thomas Weißschuh
2024-06-13 14:41 ` Lee Jones [this message]
2024-06-13 14:48 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613144137.GG2561462@google.com \
--to=lee@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mario.limonciello@amd.com \
--cc=pavel@ucw.cz \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).