From: Lee Jones <lee@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Pavel Machek <pavel@ucw.cz>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Dustin Howett <dustin@howett.net>
Subject: Re: [PATCH] leds: triggers: flush pending brightness before activating trigger
Date: Thu, 13 Jun 2024 16:02:46 +0100 [thread overview]
Message-ID: <20240613150246.GI2561462@google.com> (raw)
In-Reply-To: <20240603-led-trigger-flush-v1-1-c904c6e2fb34@weissschuh.net>
On Mon, 03 Jun 2024, Thomas Weißschuh wrote:
> The race fixed in timer_trig_activate() between a blocking
> set_brightness() call and trigger->activate() can affect any trigger.
> So move the call to flush_work() into led_trigger_set() where it can
> avoid the race for all triggers.
>
> Fixes: 0db37915d912 ("leds: avoid races with workqueue")
> Fixes: 8c0f693c6eff ("leds: avoid flush_work in atomic context")
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Dustin, could you validate that this fixes the issue you encountered in
> the cros_ec led driver?
> ---
> drivers/leds/led-triggers.c | 10 ++++++++--
> drivers/leds/trigger/ledtrig-timer.c | 5 -----
> 2 files changed, 8 insertions(+), 7 deletions(-)
This patch clashes with:
https://lore.kernel.org/all/20240531120124.75662-1-hdegoede@redhat.com/
Please rebase and ensure that your solution doesn't conflict.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-06-13 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 21:45 [PATCH] leds: triggers: flush pending brightness before activating trigger Thomas Weißschuh
2024-06-04 16:46 ` Dustin Howett
2024-06-13 15:02 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613150246.GI2561462@google.com \
--to=lee@kernel.org \
--cc=dustin@howett.net \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).