From: Bastien Curutchet <bastien.curutchet@bootlin.com>
To: Riku Voipio <riku.voipio@iki.fi>, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee@kernel.org>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
Christopher Cordahi <christophercordahi@nanometrics.ca>,
Bastien Curutchet <bastien.curutchet@bootlin.com>
Subject: [PATCH v2 0/4] leds: pca9532: Use hardware for blinking LEDs
Date: Mon, 17 Jun 2024 16:39:06 +0200 [thread overview]
Message-ID: <20240617143910.154546-1-bastien.curutchet@bootlin.com> (raw)
Hi all,
This series aims to use hardware more often to blink LEDs.
The pca9532_set_blink() rejects asymmetric delays. So the core's software
fallback is almost always used when we want to blink a LED. Removing
this restriction revealed some conflicts between setting brightness and
blinking as the same PWM (PWM0) configuration is used by all LEDs for
both brightness and blinking.
Make use of the second available PWM (PWM1) to blink LEDs. This PWM1 was
reserved for beepers so hardware blinking is explicitly disabled if at
least one LED is used to drive a beeper to avoid conflicts.
Tested with PCA9532
Changes in v2:
* Add defines to get rid of magic numbers
* Replace every 'led' by 'LED'
* Use dev_err() when returning errors
* Remove unused struct pca9532_data from patch 2 to add it on patch 3
where it's actually used
[v1] : https://lore.kernel.org/all/20240527125940.155260-1-bastien.curutchet@bootlin.com/
Bastien Curutchet (4):
leds: pca9532: Use defines to select PWM instance
leds: pca9532: Use PWM1 for hardware blinking
leds: pca9532: Explicitly disable hardware blink when PWM1 is
unavailable
leds: pca9532: Change default blinking frequency to 1Hz
drivers/leds/leds-pca9532.c | 81 ++++++++++++++++++++++++++++---------
1 file changed, 63 insertions(+), 18 deletions(-)
--
2.45.0
next reply other threads:[~2024-06-17 14:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 14:39 Bastien Curutchet [this message]
2024-06-17 14:39 ` [PATCH v2 1/4] leds: pca9532: Use defines to select PWM instance Bastien Curutchet
2024-06-17 14:39 ` [PATCH v2 2/4] leds: pca9532: Use PWM1 for hardware blinking Bastien Curutchet
2024-07-10 9:17 ` Bastien Curutchet
2024-07-11 8:30 ` Lee Jones
2024-07-11 8:40 ` Bastien Curutchet
2024-06-17 14:39 ` [PATCH v2 3/4] leds: pca9532: Explicitly disable hardware blink when PWM1 is unavailable Bastien Curutchet
2024-06-17 14:39 ` [PATCH v2 4/4] leds: pca9532: Change default blinking frequency to 1Hz Bastien Curutchet
2024-06-20 16:49 ` [PATCH v2 0/4] leds: pca9532: Use hardware for blinking LEDs Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617143910.154546-1-bastien.curutchet@bootlin.com \
--to=bastien.curutchet@bootlin.com \
--cc=christophercordahi@nanometrics.ca \
--cc=herve.codina@bootlin.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=riku.voipio@iki.fi \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).