From: Lee Jones <lee@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Pavel Machek <pavel@ucw.cz>, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-leds@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: cros_ec: Implement review comments from Lee
Date: Thu, 20 Jun 2024 18:15:11 +0100 [thread overview]
Message-ID: <20240620171511.GX3029315@google.com> (raw)
In-Reply-To: <478e23df-800a-40c6-b972-2af2d535b1ae@t-8ch.de>
On Thu, 20 Jun 2024, Thomas Weißschuh wrote:
> On 2024-06-20 13:27:41+0000, Lee Jones wrote:
> > On Thu, 20 Jun 2024, Thomas Weißschuh wrote:
> >
> > > Hi Lee,
> > >
> > > On 2024-06-20 10:31:14+0000, Lee Jones wrote:
> > > > Definitely not seen a commit message like that before
> > >
> > > I assumed that this patch would be squashed into the original commit.
> > >
> > > My question in which form you wanted the changes should have included
> > > "incremental series".
> >
> > Incremental means on top.
> >
> > A lot of maintainers don't support history re-writes, but I've reserved
> > that right since forever, so I can squash it if you like.
>
> If it is already visible somewhere and a squash would inconvenience
> anybody I'll resend it.
> But if not I'd be happy about a squash.
>
> (I couldn't and still can't find the public tree where driver is in)
Odd, neither can I! Okay applied the whole set again, squashed the
patch and submitted for testing.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-06-20 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 10:04 [PATCH] leds: cros_ec: Implement review comments from Lee Thomas Weißschuh
2024-06-20 9:31 ` Lee Jones
2024-06-20 10:12 ` Thomas Weißschuh
2024-06-20 12:27 ` Lee Jones
2024-06-20 14:38 ` Thomas Weißschuh
2024-06-20 17:15 ` Lee Jones [this message]
2024-06-20 19:02 ` Thomas Weißschuh
2024-06-21 10:40 ` Lee Jones
2024-06-21 10:44 ` Thomas Weißschuh
2024-06-20 17:13 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620171511.GX3029315@google.com \
--to=lee@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).