Re: [PATCH v7 1/3] leds: Init leds class earlier

Lee Jones
2024-09-09T09:03:46Z

On Wed, 04 Sep 2024, Mariusz Tkaczyk wrote:

> NPEM driver will require leds class, there is an init-order conflict.
> Make sure that LEDs initialization happens first and add comment.
>
> Suggested-by: Dan Williams <dan.j.williams@intel.com>

Do you have a link to this discussion?

> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
> ---
> drivers/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index fe9ceb0d2288..45d1c3e630f7 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -17,6 +17,9 @@ obj-$(CONFIG_PINCTRL) += pinctrl/
> obj-$(CONFIG_GPIOLIB) += gpio/
> obj-y += pwm/
>
> +# LEDs must come before PCI, it is needed by NPEM driver

This seems very fragile.

Isn't there a better way to describe the dependency in Kconfig etc?

> +obj-y += leds/
> +
> obj-y += pci/
>
> obj-$(CONFIG_PARISC) += parisc/
> @@ -130,7 +133,6 @@ obj-$(CONFIG_CPU_IDLE) += cpuidle/
> obj-y += mmc/
> obj-y += ufs/
> obj-$(CONFIG_MEMSTICK) += memstick/
> -obj-y += leds/
> obj-$(CONFIG_INFINIBAND) += infiniband/
> obj-y += firmware/
> obj-$(CONFIG_CRYPTO) += crypto/
> --
> 2.35.3
>

--
Lee Jones [李琼斯]