Re: [PATCH 1/2] dt-bindings: leds: bcmbca: Add bindings for BRCMBCA LEDs

[Rob Herring <robh@kernel.org>]

On Fri, Sep 20, 2024 at 01:15:12PM +0200, Linus Walleij wrote:
> The Broadcom BCA (Broadband Access) SoCs contain a unique
> LED block. Add bindings for it.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  .../devicetree/bindings/leds/brcm,bcmbca-leds.yaml | 88 ++++++++++++++++++++++
>  1 file changed, 88 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/brcm,bcmbca-leds.yaml b/Documentation/devicetree/bindings/leds/brcm,bcmbca-leds.yaml
> new file mode 100644
> index 000000000000..7fe2222c0c58
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/brcm,bcmbca-leds.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/brcm,bcmbca-leds.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCMBCA LEDs
> +
> +maintainers:
> +  - Linus Walleij <linus.walleij@linaro.org>
> +
> +description: |

Don't need '|' if no formatting.

Otherwise,

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

> +  The Broadcom BCA (Broadband Access) SoCs have a LED control
> +  block that can support either parallel (directly connected)
> +  LEDs or serial (connected to 1-4 shift registers) LEDs.
> +  The LEDs can optionally be hardware-triggered by ethernet port
> +  traffic.