linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: "Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
	"Marek Behún" <kabel@kernel.org>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Javier Carrasco <javier.carrasco.cruz@gmail.com>
Subject: [PATCH 0/6] leds: Remove local leds.h where not required
Date: Fri, 27 Sep 2024 23:37:39 +0200	[thread overview]
Message-ID: <20240927-leds_unused_leds_h-v1-0-46fbf41ed4ae@gmail.com> (raw)

There is a logical tendency to move elements from the local leds.h to
the global one under include/linux/ to make them accessible for users
outside the leds subsystem. On the other hand, some users of the local
header, which also include the global one, do not need to include it
anymore as the elements they required are no longer there.

That has been the case for leds-gpio and leds-pwm, which used to obtain
led_init_default_state_get() from that header. I could not identify the
reason why the rest of affected drivers included leds.h from the
beginning, but I suppose they used to require something that might not
be there anymore, or it was just added "by default". Either way, they
don't require it in their current form.

This series has been validated by building the kernel with both Clang
and GCC without any issues.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Javier Carrasco (6):
      leds: flash: Remove unused local leds.h
      leds: multicolor: Remove unused local leds.h
      leds: gpio: Remove unused local leds.h
      leds: lp50xx: Remove unused local leds.h
      leds: pwm: Remove unused local leds.h
      leds: turris-omnia: Remove unused local leds.h

 drivers/leds/led-class-flash.c      | 1 -
 drivers/leds/led-class-multicolor.c | 2 --
 drivers/leds/leds-gpio.c            | 2 --
 drivers/leds/leds-lp50xx.c          | 2 --
 drivers/leds/leds-pwm.c             | 1 -
 drivers/leds/leds-turris-omnia.c    | 1 -
 6 files changed, 9 deletions(-)
---
base-commit: 40e0c9d414f57d450e3ad03c12765e797fc3fede
change-id: 20240927-leds_unused_leds_h-af790ac75d80

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>


             reply	other threads:[~2024-09-27 21:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 21:37 Javier Carrasco [this message]
2024-09-27 21:37 ` [PATCH 1/6] leds: flash: Remove unused local leds.h Javier Carrasco
2024-09-27 21:37 ` [PATCH 2/6] leds: multicolor: " Javier Carrasco
2024-09-27 21:37 ` [PATCH 3/6] leds: gpio: " Javier Carrasco
2024-09-27 21:37 ` [PATCH 4/6] leds: lp50xx: " Javier Carrasco
2024-09-27 21:37 ` [PATCH 5/6] leds: pwm: " Javier Carrasco
2024-09-27 21:37 ` [PATCH 6/6] leds: turris-omnia: " Javier Carrasco
2024-10-09 14:37 ` [PATCH 0/6] leds: Remove local leds.h where not required Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240927-leds_unused_leds_h-v1-0-46fbf41ed4ae@gmail.com \
    --to=javier.carrasco.cruz@gmail.com \
    --cc=kabel@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).