[PATCH 0/6] leds: Remove local leds.h where not required

[PATCH 0/6] leds: Remove local leds.h where not required

[Javier Carrasco]

There is a logical tendency to move elements from the local leds.h to
the global one under include/linux/ to make them accessible for users
outside the leds subsystem. On the other hand, some users of the local
header, which also include the global one, do not need to include it
anymore as the elements they required are no longer there.

That has been the case for leds-gpio and leds-pwm, which used to obtain
led_init_default_state_get() from that header. I could not identify the
reason why the rest of affected drivers included leds.h from the
beginning, but I suppose they used to require something that might not
be there anymore, or it was just added "by default". Either way, they
don't require it in their current form.

This series has been validated by building the kernel with both Clang
and GCC without any issues.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Javier Carrasco (6):
      leds: flash: Remove unused local leds.h
      leds: multicolor: Remove unused local leds.h
      leds: gpio: Remove unused local leds.h
      leds: lp50xx: Remove unused local leds.h
      leds: pwm: Remove unused local leds.h
      leds: turris-omnia: Remove unused local leds.h

 drivers/leds/led-class-flash.c      | 1 -
 drivers/leds/led-class-multicolor.c | 2 --
 drivers/leds/leds-gpio.c            | 2 --
 drivers/leds/leds-lp50xx.c          | 2 --
 drivers/leds/leds-pwm.c             | 1 -
 drivers/leds/leds-turris-omnia.c    | 1 -
 6 files changed, 9 deletions(-)
---
base-commit: 40e0c9d414f57d450e3ad03c12765e797fc3fede
change-id: 20240927-leds_unused_leds_h-af790ac75d80

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>

[PATCH 1/6] leds: flash: Remove unused local leds.h

[Javier Carrasco]

This driver does not require any element from the local leds.h. Drop
unused header.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/leds/led-class-flash.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c
index 6fe9d700dfef..f4e26ce84862 100644
--- a/drivers/leds/led-class-flash.c
+++ b/drivers/leds/led-class-flash.c
@@ -12,7 +12,6 @@
 #include <linux/leds.h>
 #include <linux/module.h>
 #include <linux/slab.h>
-#include "leds.h"
 
 #define has_flash_op(fled_cdev, op)				\
 	(fled_cdev && fled_cdev->ops->op)

-- 
2.43.0

[PATCH 2/6] leds: multicolor: Remove unused local leds.h

[Javier Carrasco]

This driver does not require any element from the local leds.h. Drop
unused header.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/leds/led-class-multicolor.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/leds/led-class-multicolor.c b/drivers/leds/led-class-multicolor.c
index 30c1ecb5f361..b2a87c994816 100644
--- a/drivers/leds/led-class-multicolor.c
+++ b/drivers/leds/led-class-multicolor.c
@@ -11,8 +11,6 @@
 #include <linux/slab.h>
 #include <linux/uaccess.h>
 
-#include "leds.h"
-
 int led_mc_calc_color_components(struct led_classdev_mc *mcled_cdev,
 				 enum led_brightness brightness)
 {

-- 
2.43.0

[PATCH 3/6] leds: gpio: Remove unused local leds.h

[Javier Carrasco]

Commit 156a5bb89ca6 ("leds: Move led_init_default_state_get() to the
global header") moved the only element leds-gpio required from the local
leds.h to its global counterpart. Drop the inclusion of the local leds.h
as it is no longer used.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/leds/leds-gpio.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index 4d1612d557c8..3ccde6a5780a 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -21,8 +21,6 @@
 #include <linux/slab.h>
 #include <linux/types.h>
 
-#include "leds.h"
-
 struct gpio_led_data {
 	struct led_classdev cdev;
 	struct gpio_desc *gpiod;

-- 
2.43.0

[PATCH 4/6] leds: lp50xx: Remove unused local leds.h

[Javier Carrasco]

This driver does not require any element from the local leds.h. Drop
unused header.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/leds/leds-lp50xx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
index 175d4b06659b..a4e45078a567 100644
--- a/drivers/leds/leds-lp50xx.c
+++ b/drivers/leds/leds-lp50xx.c
@@ -16,8 +16,6 @@
 
 #include <linux/led-class-multicolor.h>
 
-#include "leds.h"
-
 #define LP50XX_DEV_CFG0		0x00
 #define LP50XX_DEV_CFG1		0x01
 #define LP50XX_LED_CFG0		0x02

-- 
2.43.0

[PATCH 5/6] leds: pwm: Remove unused local leds.h

[Javier Carrasco]

Commit 156a5bb89ca6 ("leds: Move led_init_default_state_get() to the
global header") moved the only element leds-gpio required from the local
leds.h to its global counterpart. Drop the inclusion of the local leds.h
as it is no longer used.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/leds/leds-pwm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index e1b414b40353..be4d2febf376 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -17,7 +17,6 @@
 #include <linux/err.h>
 #include <linux/pwm.h>
 #include <linux/slab.h>
-#include "leds.h"
 
 struct led_pwm {
 	const char	*name;

-- 
2.43.0

[PATCH 6/6] leds: turris-omnia: Remove unused local leds.h

[Javier Carrasco]

This driver does not require any element from the local leds.h. Drop
unused header.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/leds/leds-turris-omnia.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/leds/leds-turris-omnia.c b/drivers/leds/leds-turris-omnia.c
index 4cff8c4b020c..2de825ac08b3 100644
--- a/drivers/leds/leds-turris-omnia.c
+++ b/drivers/leds/leds-turris-omnia.c
@@ -10,7 +10,6 @@
 #include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/of.h>
-#include "leds.h"
 
 #define OMNIA_BOARD_LEDS	12
 #define OMNIA_LED_NUM_CHANNELS	3

-- 
2.43.0

Re: [PATCH 0/6] leds: Remove local leds.h where not required

[Lee Jones]

On Fri, 27 Sep 2024 23:37:39 +0200, Javier Carrasco wrote:
> There is a logical tendency to move elements from the local leds.h to
> the global one under include/linux/ to make them accessible for users
> outside the leds subsystem. On the other hand, some users of the local
> header, which also include the global one, do not need to include it
> anymore as the elements they required are no longer there.
> 
> That has been the case for leds-gpio and leds-pwm, which used to obtain
> led_init_default_state_get() from that header. I could not identify the
> reason why the rest of affected drivers included leds.h from the
> beginning, but I suppose they used to require something that might not
> be there anymore, or it was just added "by default". Either way, they
> don't require it in their current form.
> 
> [...]

Applied, thanks!

[1/6] leds: flash: Remove unused local leds.h
      commit: 827a0a3724c5e516b7c0dbfd3f0d907dc947a10b
[2/6] leds: multicolor: Remove unused local leds.h
      commit: 026432e7c26484eb613d8224c98e554c7bc7d768
[3/6] leds: gpio: Remove unused local leds.h
      commit: e7160d5ee369c016418ba239516d24f086130aa4
[4/6] leds: lp50xx: Remove unused local leds.h
      commit: d1aa93196ca601472f4300bed103ce74ff2e8a2b
[5/6] leds: pwm: Remove unused local leds.h
      commit: 9fd316962a2089f25db286c1042eeba3f08a2bed
[6/6] leds: turris-omnia: Remove unused local leds.h
      commit: 3cfd6ad3e1d9ea4ae2e13d384c3c95726593dae2

--
Lee Jones [李琼斯]