From: Thomas Zimmermann <tzimmermann@suse.de>
To: lee@kernel.org, pavel@ucw.cz, danielt@kernel.org,
jingoohan1@gmail.com, deller@gmx.de, simona@ffwll.ch
Cc: linux-leds@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 01/11] fbdev: Rework fb_blank()
Date: Wed, 26 Feb 2025 10:31:50 +0100 [thread overview]
Message-ID: <20250226093456.147402-2-tzimmermann@suse.de> (raw)
In-Reply-To: <20250226093456.147402-1-tzimmermann@suse.de>
Reimplement fb_blank() to return early on errors. No functional
changes. Prepares the helper for tracking the blanking state in
struct fb_info.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/video/fbdev/core/fbmem.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index 3c568cff2913..39e2b81473ad 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -339,11 +339,13 @@ fb_set_var(struct fb_info *info, struct fb_var_screeninfo *var)
}
EXPORT_SYMBOL(fb_set_var);
-int
-fb_blank(struct fb_info *info, int blank)
+int fb_blank(struct fb_info *info, int blank)
{
struct fb_event event;
- int ret = -EINVAL;
+ int ret;
+
+ if (!info->fbops->fb_blank)
+ return -EINVAL;
if (blank > FB_BLANK_POWERDOWN)
blank = FB_BLANK_POWERDOWN;
@@ -351,13 +353,13 @@ fb_blank(struct fb_info *info, int blank)
event.info = info;
event.data = ␣
- if (info->fbops->fb_blank)
- ret = info->fbops->fb_blank(blank, info);
+ ret = info->fbops->fb_blank(blank, info);
+ if (ret)
+ return ret;
- if (!ret)
- fb_notifier_call_chain(FB_EVENT_BLANK, &event);
+ fb_notifier_call_chain(FB_EVENT_BLANK, &event);
- return ret;
+ return 0;
}
EXPORT_SYMBOL(fb_blank);
--
2.48.1
next prev parent reply other threads:[~2025-02-26 9:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 9:31 [PATCH v2 00/11] backlight, lcd, led: Remove fbdev dependencies Thomas Zimmermann
2025-02-26 9:31 ` Thomas Zimmermann [this message]
2025-02-26 9:31 ` [PATCH v2 02/11] fbdev: Track display blanking state Thomas Zimmermann
2025-02-26 9:31 ` [PATCH v2 03/11] fbdev: Send old blank state in FB_EVENT_BLANK Thomas Zimmermann
2025-02-26 9:31 ` [PATCH v2 04/11] backlight: Implement fbdev tracking with blank state from event Thomas Zimmermann
2025-02-26 9:31 ` [PATCH v2 05/11] backlight: Move blank-state handling into helper Thomas Zimmermann
2025-02-26 9:31 ` [PATCH v2 06/11] backlight: Replace fb events with a dedicated function call Thomas Zimmermann
2025-02-27 11:42 ` kernel test robot
2025-02-27 12:46 ` kernel test robot
2025-02-26 9:31 ` [PATCH v2 07/11] backlight: lcd: Move event handling into helpers Thomas Zimmermann
2025-02-26 9:31 ` [PATCH v2 08/11] backlight: lcd: Replace fb events with a dedicated function call Thomas Zimmermann
2025-02-27 15:07 ` kernel test robot
2025-02-26 9:31 ` [PATCH v2 09/11] leds: backlight trigger: Move blank-state handling into helper Thomas Zimmermann
2025-02-26 9:31 ` [PATCH v2 10/11] leds: backlight trigger: Replace fb events with a dedicated function call Thomas Zimmermann
2025-02-26 9:32 ` [PATCH v2 11/11] fbdev: Remove constants of unused events Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226093456.147402-2-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox