From: Pengyu Luo <mitltlatltl@gmail.com>
To: Jianhua Lu <lujianhua000@gmail.com>, Lee Jones <lee@kernel.org>,
Daniel Thompson <danielt@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Helge Deller <deller@gmx.de>
Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org, Pengyu Luo <mitltlatltl@gmail.com>
Subject: [PATCH 4/4] backlight: ktz8866: add definitions to make it more readable
Date: Mon, 7 Apr 2025 17:51:19 +0800 [thread overview]
Message-ID: <20250407095119.588920-5-mitltlatltl@gmail.com> (raw)
In-Reply-To: <20250407095119.588920-1-mitltlatltl@gmail.com>
LSB, MSB and their handling are slightly confused, so improve it.
Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
---
drivers/video/backlight/ktz8866.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/ktz8866.c b/drivers/video/backlight/ktz8866.c
index b67ca136d..5364ecfc0 100644
--- a/drivers/video/backlight/ktz8866.c
+++ b/drivers/video/backlight/ktz8866.c
@@ -24,7 +24,9 @@
#define DEVICE_ID 0x01
#define BL_CFG1 0x02
#define BL_CFG2 0x03
+/* least significant byte */
#define BL_BRT_LSB 0x04
+/* most significant byte */
#define BL_BRT_MSB 0x05
#define BL_EN 0x08
#define LCD_BIAS_CFG1 0x09
@@ -47,6 +49,8 @@
#define PWM_HYST 0x5
#define CURRENT_SINKS_MASK GENMASK(5, 0)
+#define LOWER_BYTE GENMASK(2, 0)
+#define HIGHER_BYTE GENMASK(10, 3)
struct ktz8866_slave {
struct i2c_client *client;
@@ -105,8 +109,8 @@ static int ktz8866_backlight_update_status(struct backlight_device *backlight_de
}
/* Set brightness */
- ktz8866_write(ktz, BL_BRT_LSB, brightness & 0x7);
- ktz8866_write(ktz, BL_BRT_MSB, (brightness >> 3) & 0xFF);
+ ktz8866_write(ktz, BL_BRT_LSB, FIELD_GET(LOWER_BYTE, brightness);
+ ktz8866_write(ktz, BL_BRT_MSB, FIELD_GET(HIGHER_BYTE, brightness);
return 0;
}
--
2.49.0
next prev parent reply other threads:[~2025-04-07 9:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 9:51 [PATCH 0/4] backlight: ktz8866: improve it and support slave Pengyu Luo
2025-04-07 9:51 ` [PATCH 1/4] dt-bindings: backlight: kinetic,ktz8866: add ktz8866 slave compatible Pengyu Luo
2025-04-07 9:57 ` Krzysztof Kozlowski
2025-04-07 9:51 ` [PATCH 2/4] backlight: ktz8866: add slave handler Pengyu Luo
2025-04-07 10:00 ` Krzysztof Kozlowski
2025-04-18 18:14 ` Pengyu Luo
2025-04-18 18:17 ` Pengyu Luo
2025-04-07 16:27 ` Daniel Thompson
2025-04-18 18:19 ` Pengyu Luo
2025-04-07 9:51 ` [PATCH 3/4] backlight: ktz8866: improve current sinks setting Pengyu Luo
2025-04-07 16:13 ` Daniel Thompson
2025-04-08 3:45 ` kernel test robot
2025-04-08 3:55 ` kernel test robot
2025-04-07 9:51 ` Pengyu Luo [this message]
2025-04-07 16:18 ` [PATCH 4/4] backlight: ktz8866: add definitions to make it more readable Daniel Thompson
2025-04-08 5:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407095119.588920-5-mitltlatltl@gmail.com \
--to=mitltlatltl@gmail.com \
--cc=conor+dt@kernel.org \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox