linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Leitner <richard.leitner@linux.dev>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
	 Dave Stevenson <dave.stevenson@raspberrypi.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	Lee Jones <lee@kernel.org>,  Pavel Machek <pavel@kernel.org>,
	 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
	linux-media@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org,
	 Richard Leitner <richard.leitner@linux.dev>
Subject: [PATCH v4 01/10] media: v4l: ctrls: add a control for flash/strobe duration
Date: Wed, 07 May 2025 09:51:30 +0200	[thread overview]
Message-ID: <20250507-ov9282-flash-strobe-v4-1-72b299c1b7c9@linux.dev> (raw)
In-Reply-To: <20250507-ov9282-flash-strobe-v4-0-72b299c1b7c9@linux.dev>

Add a control V4L2_CID_FLASH_DURATION to set the duration of a
flash/strobe pulse. This is different to the V4L2_CID_FLASH_TIMEOUT
control, as the timeout defines a limit after which the flash is
"forcefully" turned off again.

On the other hand the new V4L2_CID_FLASH_DURATION is the desired length
of the flash/strobe pulse.

Signed-off-by: Richard Leitner <richard.leitner@linux.dev>
---
 drivers/media/v4l2-core/v4l2-ctrls-defs.c | 1 +
 include/uapi/linux/v4l2-controls.h        | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/media/v4l2-core/v4l2-ctrls-defs.c b/drivers/media/v4l2-core/v4l2-ctrls-defs.c
index 1ea52011247accc51d0261f56eab1cf13c0624a0..f9ed7273a9f3eafe01c31b638e1c8d9fcf5424af 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls-defs.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls-defs.c
@@ -1135,6 +1135,7 @@ const char *v4l2_ctrl_get_name(u32 id)
 	case V4L2_CID_FLASH_FAULT:		return "Faults";
 	case V4L2_CID_FLASH_CHARGE:		return "Charge";
 	case V4L2_CID_FLASH_READY:		return "Ready to Strobe";
+	case V4L2_CID_FLASH_DURATION:		return "Strobe Duration";
 
 	/* JPEG encoder controls */
 	/* Keep the order of the 'case's the same as in v4l2-controls.h! */
diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
index 72e32814ea83dee5f1202c1249eac7cf3b85a22a..72c6bd26e2dfa23a0224e745e5cd07c9fca0c8b5 100644
--- a/include/uapi/linux/v4l2-controls.h
+++ b/include/uapi/linux/v4l2-controls.h
@@ -1180,6 +1180,7 @@ enum v4l2_flash_strobe_source {
 
 #define V4L2_CID_FLASH_CHARGE			(V4L2_CID_FLASH_CLASS_BASE + 11)
 #define V4L2_CID_FLASH_READY			(V4L2_CID_FLASH_CLASS_BASE + 12)
+#define V4L2_CID_FLASH_DURATION			(V4L2_CID_FLASH_CLASS_BASE + 13)
 
 
 /* JPEG-class control IDs */

-- 
2.47.2



  reply	other threads:[~2025-05-07  7:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07  7:51 [PATCH v4 00/10] Add strobe/flash duration v4l2 ctrl & use it for ov9282 Richard Leitner
2025-05-07  7:51 ` Richard Leitner [this message]
2025-05-07  7:51 ` [PATCH v4 02/10] leds: flash: add support for flash/stobe duration Richard Leitner
2025-05-13 10:08   ` (subset) " Lee Jones
2025-05-07  7:51 ` [PATCH v4 03/10] media: v4l2-flash: add support for flash/strobe duration Richard Leitner
2025-05-07  7:51 ` [PATCH v4 04/10] media: v4l2-flash: fix flash_timeout comment Richard Leitner
2025-05-07  7:51 ` [PATCH v4 05/10] Documentation: uAPI: media: add V4L2_CID_FLASH_DURATION Richard Leitner
2025-05-07  7:51 ` [PATCH v4 06/10] media: i2c: ov9282: add output enable register definitions Richard Leitner
2025-05-07  7:51 ` [PATCH v4 07/10] media: i2c: ov9282: add led_mode v4l2 control Richard Leitner
2025-05-26 20:41   ` Sakari Ailus
2025-05-28 12:15     ` Richard Leitner
2025-05-07  7:51 ` [PATCH v4 08/10] media: i2c: ov9282: add strobe_duration " Richard Leitner
2025-05-26 20:27   ` Sakari Ailus
2025-06-16 22:11     ` Richard Leitner
2025-05-07  7:51 ` [PATCH v4 09/10] media: i2c: ov9282: add strobe_source " Richard Leitner
2025-05-26 20:24   ` Sakari Ailus
2025-05-28  9:46     ` Richard Leitner
2025-05-07  7:51 ` [PATCH v4 10/10] media: i2c: ov9282: implement try_ctrl for strobe_duration Richard Leitner
2025-05-26 20:22   ` Sakari Ailus
2025-05-28  9:25     ` Richard Leitner
2025-05-26 18:41 ` [PATCH v4 00/10] Add strobe/flash duration v4l2 ctrl & use it for ov9282 Richard Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250507-ov9282-flash-strobe-v4-1-72b299c1b7c9@linux.dev \
    --to=richard.leitner@linux.dev \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=hverkuil@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pavel@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).