From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C160D188006; Tue, 17 Jun 2025 17:08:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750180100; cv=none; b=MfnCkx1BPSAcJuykApjw7gGfbfdztesqr6MFngPxugcaH0jpB0XC+tqxTGMKDj8ZN8IskZttqiHBA3PVNvCIjak4xOrxEiX0OC8gbYmwT0WOpayNQpGBGRJcnFEpGiG1G5iNXP2fo8rtPcKOYdFWhZCNdQqnh0yP75ncbJLPCF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750180100; c=relaxed/simple; bh=MC5yXiem/XiAOYUpnP0gGjuW0GwRYpDD+n69a4aKMJQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eNzdBQ0AqfwmSQYUoq0VBiLirZ3uGl+u8NWv0eIFSdxd/ZgmnCsHEmR3euGN1HNj4OTz7KYr9Q8/pLYuiJxuxfQrt5IvykSFev1YegwiG04fdta0uz0N7K+S3vaGNAFxU+KovIlLK98/YDLPc0iRwrpNiFZotjsby+KwMBA05ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=cyJeSIYK; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="cyJeSIYK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1750180095; bh=MC5yXiem/XiAOYUpnP0gGjuW0GwRYpDD+n69a4aKMJQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=cyJeSIYKTkiOrYuqpZKDsNZ6dqqRK/AbUA6Dwz77IgJ4xLP53jwNmt4GzOBZevCwf ZBZ8wV8viSftEVK9yJgR523I219n53heonys9/4FJlTs1v5FnYTzfuFqa2xo69OAm3 OJKCnt2tVv28aiPtar9iQ5Hb2j8oHpJQb0eJ+N9Q= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Tue, 17 Jun 2025 19:08:12 +0200 Subject: [PATCH v7 1/3] spi: spi-nxp-fspi: check return value of devm_mutex_init() Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20250617-must_check-devm_mutex_init-v7-1-d9e449f4d224@weissschuh.net> References: <20250617-must_check-devm_mutex_init-v7-0-d9e449f4d224@weissschuh.net> In-Reply-To: <20250617-must_check-devm_mutex_init-v7-0-d9e449f4d224@weissschuh.net> To: Peter Zijlstra , Ingo Molnar , Waiman Long , Boqun Feng , Vicentiu Galanopulo , Will Deacon , Han Xu , Haibo Chen , Yogesh Gaur , Mark Brown , Lee Jones , Pavel Machek , Andrew Davis Cc: Andy Shevchenko , linux-kernel@vger.kernel.org, Bartosz Golaszewski , Bartosz Golaszewski , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-leds@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1750180094; l=1010; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=MC5yXiem/XiAOYUpnP0gGjuW0GwRYpDD+n69a4aKMJQ=; b=f4c7YwjcV/UL1ks9Ly8Byx44jZAWULoi9GjwjUjYlbG84xBpsbwHzyUiQd8EhePjN72ThBmAV NC9+IUFuTaWApURrOV2QgGSlId0B5bMlzbfUWSEVw3efoRIQsBZcPKZ X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= devm_mutex_init() can fail. With CONFIG_DEBUG_MUTEXES=y the mutex will be marked as unusable and trigger errors on usage. Add the missed check. Fixes: 48900813abd2 ("spi: spi-nxp-fspi: remove the goto in probe") Signed-off-by: Thomas Weißschuh --- drivers/spi/spi-nxp-fspi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index e63c77e418231cd0698ffb73eeeebfbe63cc3065..f3d5765054132cd18b7257439ece971f58e9ceb2 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -1273,7 +1273,9 @@ static int nxp_fspi_probe(struct platform_device *pdev) if (ret) return dev_err_probe(dev, ret, "Failed to request irq\n"); - devm_mutex_init(dev, &f->lock); + ret = devm_mutex_init(dev, &f->lock); + if (ret) + return dev_err_probe(dev, ret, "Failed to initialize lock\n"); ctlr->bus_num = -1; ctlr->num_chipselect = NXP_FSPI_MAX_CHIPSELECT; -- 2.50.0