From: Nam Tran <trannamatk@gmail.com>
To: lee@kernel.org, krzk+dt@kernel.org
Cc: pavel@kernel.org, rdunlap@infradead.org,
christophe.jaillet@wanadoo.fr, robh@kernel.org,
conor+dt@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v11 2/4] leds: add basic support for TI/National Semiconductor LP5812 LED Driver
Date: Wed, 30 Jul 2025 11:08:39 +0700 [thread overview]
Message-ID: <20250730040839.125683-1-trannamatk@gmail.com> (raw)
In-Reply-To: <bc24e841-94a8-4ca8-9f69-90ec32fbbfca@kernel.org>
On Tue, 29 Jul 2025, Krzysztof Kozlowski wrote:
> On 28/07/2025 08:58, Nam Tran wrote:
>
> ...
>
> > +MODULE_DEVICE_TABLE(of, of_lp5812_match);
> > +
> > +static struct i2c_driver lp5812_driver = {
> > + .driver = {
> > + .name = "lp5812",
> > + .of_match_table = of_match_ptr(of_lp5812_match),
>
> v11 was okay here... now you introduced errors.
Thank you for pointing that out.
You're absolutely right.
Since the LP5812 driver is DT-only and doesn't support non-DT probing,
using of_match_ptr() is unnecessary and potentially incorrect.
I'll drop of_match_ptr() and directly assign the of_match_table.
Thanks again for the review!
Best regards,
Nam Tran
next prev parent reply other threads:[~2025-07-30 4:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 6:58 [PATCH v12 0/4] leds: add new LED driver for TI LP5812 Nam Tran
2025-07-28 6:58 ` [PATCH v12 1/4] dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver Nam Tran
2025-07-28 6:58 ` [PATCH v12 2/4] leds: add basic support for " Nam Tran
2025-07-28 23:36 ` kernel test robot
2025-07-29 6:40 ` Krzysztof Kozlowski
2025-07-30 4:08 ` Nam Tran [this message]
2025-07-28 6:58 ` [PATCH v12 3/4] docs: ABI: Document LP5812 LED sysfs interfaces Nam Tran
2025-07-28 6:58 ` [PATCH v12 4/4] docs: leds: Document TI LP5812 LED driver Nam Tran
-- strict thread matches above, loose matches on Subject: below --
2025-07-14 17:23 [PATCH v11 0/4] leds: add new LED driver for TI LP5812 Nam Tran
2025-07-14 17:23 ` [PATCH v11 2/4] leds: add basic support for TI/National Semiconductor LP5812 LED Driver Nam Tran
2025-07-18 8:04 ` Krzysztof Kozlowski
2025-07-23 15:32 ` Nam Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730040839.125683-1-trannamatk@gmail.com \
--to=trannamatk@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).