From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7B91280309; Tue, 2 Sep 2025 10:26:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756808802; cv=none; b=eoAb45TeiyljcazfG+hwgGC8xn+0g13stakI/1qJTyRlds4sZwosFHrLybSe58+NPR+/CX/39T+TGv0Lk/YnbfbmjsMY7kSJZwA3bve+xOvCsuvHeEs5jw8bwd56HCJlEGyEZpFBszdj8okLPLgS9H0So1ZdJ61EugZyX6leFPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756808802; c=relaxed/simple; bh=lToFDrcgaN9qTLhM+wiTddSLncDaBi7MkVCs9D8u8nA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qrZALjuoJtRUGU7aEwkczn5XAIqOab2aRlHUdhGKV8KWDJYZAaJAjGL0IDhBsGk7ZTO3Np4wiVznkRPYczy6q5Pa1clrDcdRcykPE1FJgT7Qz7sZNkzQyzzJ0BmTDbSs3dA4uWEGE0mnt59mPUCRvLAarz3mr58QNBghoxmp8oo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mu7vfGrO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mu7vfGrO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ACA0C4CEED; Tue, 2 Sep 2025 10:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756808801; bh=lToFDrcgaN9qTLhM+wiTddSLncDaBi7MkVCs9D8u8nA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mu7vfGrO9HoMK2J+ETopLTQqJt/Ku5I5gDUIi1Q9FOhHe3A4wKW2p+i6h0+7/yVOM VF0vv3lXYFrihh/dzfR2XvV0gSY4Hk+f9CaQDH4pUJYZCfAAMILZS/+/7K+tGoZAdY GuAZlz32I66tuhpm61FimNXeF5uHcRUODQKem5hPtIVa5+Whi8R/JXy1KBUmlKS2m/ vgPRDv42WLRzwTAXtt9fzby9a2ebjskx4Jbut0DraugS1ypHEq1+S89F5y919SWdXl nxyzblGc7OqK92k5nLOM8JSR5ZojWwCWznvhkb4+Z03SCpIIzmKZSU0LmBpG4hQmdE +C5O5seSDVrlg== Date: Tue, 2 Sep 2025 11:26:36 +0100 From: Lee Jones To: LI Qingwu Cc: "pavel@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V8 2/2] leds: pwm: Add optional GPIO enable pin support Message-ID: <20250902102636.GF2163762@google.com> References: <20250724080221.7562-1-Qing-wu.Li@leica-geosystems.com.cn> <20250724080221.7562-3-Qing-wu.Li@leica-geosystems.com.cn> <20250731104623.GD1049189@google.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, 12 Aug 2025, LI Qingwu wrote: > > > > -----Original Message----- > > From: Lee Jones > > Sent: Thursday, July 31, 2025 6:46 PM > > To: LI Qingwu > > Cc: pavel@kernel.org; robh@kernel.org; krzk+dt@kernel.org; > > conor+dt@kernel.org; linux-leds@vger.kernel.org; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org > > Subject: Re: [PATCH V8 2/2] leds: pwm: Add optional GPIO enable pin support > > > > > > On Thu, 24 Jul 2025, LI Qingwu wrote: > > > > > Add support for optional GPIO-based enable pin control to PWM LED driver. > > > Some PWM LED driver chips like TPS92380 and LT3743 require a separate > > > enable signal in addition to PWM control. Implement support for such > > > GPIO control through the "enable-gpios" device tree property, > > > activating the pin when LED brightness is non-zero and deactivating it when > > off. > > > > > > Tested on i.MX8MP EVK with TPS92380 LED driver chip > > > > > > Signed-off-by: LI Qingwu > > > --- > > > drivers/leds/leds-pwm.c | 20 ++++++++++++++++++++ > > > 1 file changed, 20 insertions(+) > > > > > > diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c index > > > c73134e7b9514..08a1f735166ad 100644 > > > --- a/drivers/leds/leds-pwm.c > > > +++ b/drivers/leds/leds-pwm.c > > > @@ -17,6 +17,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > This list is alphabetical. > > > The original code's include order is not alphabetical, > If you prefer, I can reorder all or just put "#include " to first line, > Please let me know your preference. First line is okay for now. Then, if you feel like it, submit another patch to place them in order. -- Lee Jones [李琼斯]