Linux LED subsystem development
 help / color / mirror / Atom feed
From: Aleksandrs Vinarskis <alex@vinarskis.com>
To: Hans de Goede <hansg@kernel.org>, Lee Jones <lee@kernel.org>,
	 Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	 Jingoo Han <jingoohan1@gmail.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
	 Jacopo Mondi <jacopo@jmondi.org>,
	 Sakari Ailus <sakari.ailus@linux.intel.com>,
	 Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	 Daniel Thompson <danielt@kernel.org>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	 threeway@gmail.com, Andy Shevchenko <andy.shevchenko@gmail.com>,
	 Aleksandrs Vinarskis <alex@vinarskis.com>
Subject: [PATCH v5 4/4] arm64: dts: qcom: sc8280xp-x13s: enable camera privacy indicator
Date: Wed, 10 Sep 2025 14:01:11 +0200	[thread overview]
Message-ID: <20250910-leds-v5-4-bb90a0f897d5@vinarskis.com> (raw)
In-Reply-To: <20250910-leds-v5-0-bb90a0f897d5@vinarskis.com>

Leverage newly introduced 'leds' and 'led-names' properties to pass
indicator's phandle and function to v4l2 subnode. The latter supports
privacy led since couple of years ago under 'privacy-led' designation.
Unlike initially proposed trigger-source based approach, this solution
cannot be easily bypassed from userspace, thus reducing privacy
concerns.

Signed-off-by: Aleksandrs Vinarskis <alex@vinarskis.com>
---
 arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 637430719e6d7d3c0eeb4abf2b80eea1f8289530..3b3f7137689a6fa292ffe4fec8c1d1f20ee525bc 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -83,14 +83,11 @@ leds {
 		pinctrl-names = "default";
 		pinctrl-0 = <&cam_indicator_en>;
 
-		led-camera-indicator {
-			label = "white:camera-indicator";
+		privacy_led: privacy-led {
 			function = LED_FUNCTION_INDICATOR;
 			color = <LED_COLOR_ID_WHITE>;
 			gpios = <&tlmm 28 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "none";
 			default-state = "off";
-			/* Reuse as a panic indicator until we get a "camera on" trigger */
 			panic-indicator;
 		};
 	};
@@ -685,6 +682,9 @@ camera@10 {
 		pinctrl-names = "default";
 		pinctrl-0 = <&cam_rgb_default>;
 
+		leds = <&privacy_led>;
+		led-names = "privacy";
+
 		clocks = <&camcc CAMCC_MCLK3_CLK>;
 
 		orientation = <0>;	/* Front facing */

-- 
2.48.1


  parent reply	other threads:[~2025-09-10 12:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10 12:01 [PATCH v5 0/4] leds: privacy-led support for devicetree Aleksandrs Vinarskis
2025-09-10 12:01 ` [PATCH v5 1/4] dt-bindings: leds: add generic LED consumer documentation Aleksandrs Vinarskis
2025-09-15  0:01   ` Rob Herring (Arm)
2025-09-10 12:01 ` [PATCH v5 2/4] dt-bindings: leds: commonize leds property Aleksandrs Vinarskis
2025-09-15  0:01   ` Rob Herring (Arm)
2025-09-10 12:01 ` [PATCH v5 3/4] leds: led-class: Add devicetree support to led_get() Aleksandrs Vinarskis
2025-09-10 12:22   ` Konrad Dybcio
2025-09-10 12:54     ` Aleksandrs Vinarskis
2025-09-10 13:00       ` Konrad Dybcio
2025-09-11  8:15   ` Lee Jones
2025-09-11  9:01     ` Hans de Goede
2025-09-16 15:43       ` Bjorn Andersson
2025-09-16 16:07         ` Lee Jones
2025-09-23  8:36           ` Aleksandrs Vinarskis
2025-09-10 12:01 ` Aleksandrs Vinarskis [this message]
2025-09-10 12:21   ` [PATCH v5 4/4] arm64: dts: qcom: sc8280xp-x13s: enable camera privacy indicator Konrad Dybcio
2025-09-10 17:04   ` Steev Klimaszewski
2025-09-10 17:47     ` Steev Klimaszewski
2025-09-16 14:52 ` (subset) [PATCH v5 0/4] leds: privacy-led support for devicetree Lee Jones
2025-10-30 16:25 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250910-leds-v5-4-bb90a0f897d5@vinarskis.com \
    --to=alex@vinarskis.com \
    --cc=andersson@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=danielt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hansg@kernel.org \
    --cc=jacopo@jmondi.org \
    --cc=jingoohan1@gmail.com \
    --cc=jjhiblot@traphandler.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pavel@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=threeway@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox