From: Andrew Davis <afd@ti.com>
To: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
David Owens <daowens01@gmail.com>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Andrew Davis <afd@ti.com>
Subject: [PATCH 1/5] leds: lp8860: Use a single regmap table
Date: Thu, 5 Mar 2026 14:37:02 -0600 [thread overview]
Message-ID: <20260305203706.841384-1-afd@ti.com> (raw)
Instead of a regmap table each for the normal registers and the EEPROM
registers, make one table and use an access table to prevent read/write
to/from the registers between the two ranges. Slightly simplifies the
code.
Signed-off-by: Andrew Davis <afd@ti.com>
---
drivers/leds/leds-lp8860.c | 28 +++++++++++-----------------
1 file changed, 11 insertions(+), 17 deletions(-)
diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c
index 0962c00c215a1..87d298b6be7d0 100644
--- a/drivers/leds/leds-lp8860.c
+++ b/drivers/leds/leds-lp8860.c
@@ -89,14 +89,12 @@
* @client: Pointer to the I2C client
* @led_dev: led class device pointer
* @regmap: Devices register map
- * @eeprom_regmap: EEPROM register map
*/
struct lp8860_led {
struct mutex lock;
struct i2c_client *client;
struct led_classdev led_dev;
struct regmap *regmap;
- struct regmap *eeprom_regmap;
};
static const struct reg_sequence lp8860_eeprom_disp_regs[] = {
@@ -231,7 +229,7 @@ static int lp8860_init(struct lp8860_led *led)
}
reg_count = ARRAY_SIZE(lp8860_eeprom_disp_regs);
- ret = regmap_multi_reg_write(led->eeprom_regmap, lp8860_eeprom_disp_regs, reg_count);
+ ret = regmap_multi_reg_write(led->regmap, lp8860_eeprom_disp_regs, reg_count);
if (ret) {
dev_err(&led->client->dev, "Failed writing EEPROM\n");
goto out;
@@ -255,17 +253,21 @@ static int lp8860_init(struct lp8860_led *led)
return ret;
}
-static const struct regmap_config lp8860_regmap_config = {
- .reg_bits = 8,
- .val_bits = 8,
+static const struct regmap_range lp8860_reg_ranges[] = {
+ regmap_reg_range(LP8860_DISP_CL1_BRT_MSB, LP8860_EEPROM_UNLOCK),
+ regmap_reg_range(LP8860_EEPROM_REG_0, LP8860_EEPROM_REG_24),
+};
- .max_register = LP8860_EEPROM_UNLOCK,
+static const struct regmap_access_table lp8860_reg_table = {
+ .yes_ranges = lp8860_reg_ranges,
+ .n_yes_ranges = ARRAY_SIZE(lp8860_reg_ranges),
};
-static const struct regmap_config lp8860_eeprom_regmap_config = {
+static const struct regmap_config lp8860_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
-
+ .rd_table = &lp8860_reg_table,
+ .wr_table = &lp8860_reg_table,
.max_register = LP8860_EEPROM_REG_24,
};
@@ -319,14 +321,6 @@ static int lp8860_probe(struct i2c_client *client)
return ret;
}
- led->eeprom_regmap = devm_regmap_init_i2c(client, &lp8860_eeprom_regmap_config);
- if (IS_ERR(led->eeprom_regmap)) {
- ret = PTR_ERR(led->eeprom_regmap);
- dev_err(&client->dev, "Failed to allocate register map: %d\n",
- ret);
- return ret;
- }
-
ret = lp8860_init(led);
if (ret)
return ret;
--
2.39.2
next reply other threads:[~2026-03-05 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 20:37 Andrew Davis [this message]
2026-03-05 20:37 ` [PATCH 2/5] leds: lp8860: Return directly from lp8860_init Andrew Davis
2026-03-05 20:37 ` [PATCH 3/5] leds: lp8860: Hold lock for all of EEPROM programming Andrew Davis
2026-03-05 20:37 ` [PATCH 4/5] leds: lp8860: Remove unused read of STATUS register Andrew Davis
2026-03-05 20:37 ` [PATCH 5/5] leds: lp8860: Do not always program EEPROM on probe Andrew Davis
2026-03-09 18:49 ` [PATCH 1/5] leds: lp8860: Use a single regmap table Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305203706.841384-1-afd@ti.com \
--to=afd@ti.com \
--cc=daowens01@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox