From: Andrew Davis <afd@ti.com>
To: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
David Owens <daowens01@gmail.com>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Andrew Davis <afd@ti.com>
Subject: [PATCH 4/5] leds: lp8860: Remove unused read of STATUS register
Date: Thu, 5 Mar 2026 14:37:05 -0600 [thread overview]
Message-ID: <20260305203706.841384-4-afd@ti.com> (raw)
In-Reply-To: <20260305203706.841384-1-afd@ti.com>
This register is read but the contents are never checked, remove
the read until we add status checking. While here add an error
message should the preceding fault check fail.
Signed-off-by: Andrew Davis <afd@ti.com>
---
drivers/leds/leds-lp8860.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c
index 16129ae94d65f..6d1c9434e6d17 100644
--- a/drivers/leds/leds-lp8860.c
+++ b/drivers/leds/leds-lp8860.c
@@ -185,18 +185,15 @@ static int lp8860_brightness_set(struct led_classdev *led_cdev,
static int lp8860_program_eeprom(struct lp8860_led *led)
{
- unsigned int read_buf;
int ret, reg_count;
guard(mutex)(&led->lock);
ret = lp8860_fault_check(led);
- if (ret)
- return ret;
-
- ret = regmap_read(led->regmap, LP8860_STATUS, &read_buf);
- if (ret)
+ if (ret) {
+ dev_err(&led->client->dev, "Cannot read/clear faults\n");
return ret;
+ }
ret = regmap_write(led->regmap, LP8860_EEPROM_UNLOCK, LP8860_EEPROM_CODE_1);
if (ret) {
--
2.39.2
next prev parent reply other threads:[~2026-03-05 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 20:37 [PATCH 1/5] leds: lp8860: Use a single regmap table Andrew Davis
2026-03-05 20:37 ` [PATCH 2/5] leds: lp8860: Return directly from lp8860_init Andrew Davis
2026-03-05 20:37 ` [PATCH 3/5] leds: lp8860: Hold lock for all of EEPROM programming Andrew Davis
2026-03-05 20:37 ` Andrew Davis [this message]
2026-03-05 20:37 ` [PATCH 5/5] leds: lp8860: Do not always program EEPROM on probe Andrew Davis
2026-03-09 18:49 ` [PATCH 1/5] leds: lp8860: Use a single regmap table Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305203706.841384-4-afd@ti.com \
--to=afd@ti.com \
--cc=daowens01@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox