From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62726273803 for ; Fri, 6 Mar 2026 11:32:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772796746; cv=none; b=XkSFmmZKjXCuyK/QzNJIvCEykandggSBlKyDTdSXEMR1DMkGl5ig5wzhWVwrB4R1fnwuk90oIy5nbkfMBUN+Ko3XI68y0W8eXQR0DhDD4UVdo6XAiQDVh90Z20NJKIXB02OYRpBgVffAd8LF4U3DnH10pw7cF2O4b0lZLBFqSJ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772796746; c=relaxed/simple; bh=ze8UGvxgmXBJBZvoVM5cZ5bIqoD3x9eqbFCPcoWbC1s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kx6Y92rhIknTFIUqdnZWg9i3Uu7x4s/u8PnLdz/Onxu4zzw3319ChTpEWDcM7suSKNrqB+mhj8lBIfXqMOFpQMb5kHtT7/QXjzFhsdrCxcJcaZCmtUKgQuj6Rqoa1z1One8PIvbIFkUYUaQtWePP1vC9SfKo9wq5P6BCp4DQwTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EOUVZhfU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EOUVZhfU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74504C4CEF7; Fri, 6 Mar 2026 11:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772796746; bh=ze8UGvxgmXBJBZvoVM5cZ5bIqoD3x9eqbFCPcoWbC1s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EOUVZhfU+HQ4OltB8x0hM09npM9yFJxVnvqjNOwdp+JKkokvjsh8WV6F2RhIPhx4R 96Dw/PqqykCpc9lVn4akIrOpJm1djAMxDGpWg0blEZdnQCYs/gLoPY3QSmKfqnXEy4 3pbn9CiVi8P1xFzrg6utP0cEiQe4H7fDzMzYjqq6GLpCmho39SlS0aCByyJaz5p/W9 w7jWMErsYIsSESXb/K2DIkpsvMH5e9SV9g1XZh41AwmJrX4XuXutAnWCTLpHTJ1OG6 12j7OQ0xw8puV7GXspT/6EX8YQKAZOHoB4WO3IGkAbA+i/toc6cdDz3I4vGdnJe+6y BLIiY8QSH+FUg== Date: Fri, 6 Mar 2026 11:32:21 +0000 From: Lee Jones To: Andy Shevchenko Cc: Michael Tretter , Pavel Machek , linux-leds@vger.kernel.org, kernel@pengutronix.de, Thorsten Schmelzer Subject: Re: [PATCH] leds: led-class: detect brightness conversion base from string Message-ID: <20260306113221.GI183676@google.com> References: <20260123-leds-class-convert-brightness-value-v1-1-ae9d3ae4224b@pengutronix.de> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, 05 Mar 2026, Andy Shevchenko wrote: > On Fri, Jan 23, 2026 at 10:57:26AM +0100, Michael Tretter wrote: > > From: Thorsten Schmelzer > > > > sysfs-class-led doesn't specify the number format for the brightness, > > but the class only accepts base 10 numbers. > > > > Use the automatic base detection of kstrtoul and accept the brightness > > as hex value as well. > > This obviously brings a regression. > Previously the 000000000000100 is 100, now it's 64. > > While I don't care much (I even like the change), I have to point this out. > > The correct fix is to update documentation. Again, should we remove this patch that you like? -- Lee Jones [李琼斯]