Re: [PATCH] leds: led-class: detect brightness conversion base from string

[Lee Jones <lee@kernel.org>]

On Fri, 06 Mar 2026, Andy Shevchenko wrote:

> On Fri, Mar 06, 2026 at 11:32:21AM +0000, Lee Jones wrote:
> > On Thu, 05 Mar 2026, Andy Shevchenko wrote:
> > > On Fri, Jan 23, 2026 at 10:57:26AM +0100, Michael Tretter wrote:
> > > > From: Thorsten Schmelzer <tschmelzer@topcon.com>
> > > > 
> > > > sysfs-class-led doesn't specify the number format for the brightness,
> > > > but the class only accepts base 10 numbers.
> > > > 
> > > > Use the automatic base detection of kstrtoul and accept the brightness
> > > > as hex value as well.
> > > 
> > > This obviously brings a regression.
> > > Previously the 000000000000100 is 100, now it's 64.
> > > 
> > > While I don't care much (I even like the change), I have to point this out.
> > > 
> > > The correct fix is to update documentation.
> > 
> > Again, should we remove this patch that you like?
> 
> Depends if anybody outside relies on the above mentioned decimal values
> with leading 0(s). On the safest side is better to drop (and explain in
> the documentation that the values are decimal).

For the fear of breaking userspace, I have dropped the patch.

Please could someone update the docs?

-- 
Lee Jones [李琼斯]