From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CD6443CEF7 for ; Tue, 10 Mar 2026 09:23:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773134605; cv=none; b=qy4ngM17lH2YL8PZKrmqELf4sAahokdr95eKKJyi0sI4TECBOpMd2fzNExxNJ74o3OxytH4m4owDvN+QLobHUQ47mkBUUwNPUdMaoGa5ZFxuTB8JQhhNUcbhLOZLspJe5R8qTpnUXB1AN6Y4DVznxrKSUwUPfewJHZ81PxAeVls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773134605; c=relaxed/simple; bh=k8NuUYmwWEnSpYSDx/7NXzrrywXpfdf9wA2VsksW4ZI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uyQfcVFzWpp1Wjjb69G9iMZeyg8zkkcC4BkB6ESprk4OcW5OKZ6RhFUNgxwdCutG8HFUUfvK8TBTvOMSrVS3X2NSi9ilCoGO21aHUT8dHjnCg+C8f88OoubqrhQJb+FcIM8t4hxwWuiNoyitcH5uS7m3728IA2WKVAAZP8lRGMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e0iTwkdL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e0iTwkdL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8766CC2BC86; Tue, 10 Mar 2026 09:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773134605; bh=k8NuUYmwWEnSpYSDx/7NXzrrywXpfdf9wA2VsksW4ZI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e0iTwkdLzt3FOAoPMq4YX34MvrmgLLLp7SJUeiP47wZ54xLjtzUdiPLpKSjqy4Ibc GjTJElexPdAOp4APUsPC6zPzYsI6TVhf5Pn7njothwVs1SNvQP9GsaJLclWL5vB9Bl ovRxHH4k5o+pmj9OgBIeHUL+Kc7MuMLiFKst2KTo+GOQecn3GWll1njAMW1BCXldIb vAblG7+BHP71DcfqMzRkJbm19tIutDD3dtrev7qradHnuDMLhF0H7PJJqx2cTeFVc+ lyiuDBJpt6u4Kkpw8PLu5vyIn0cE6EWscrMajlxmAVYz++ZgHT/JSriWkJABvn/QH7 4YuvuFy5mUpTw== Date: Tue, 10 Mar 2026 09:23:19 +0000 From: Lee Jones To: Andy Shevchenko Cc: Michael Tretter , Pavel Machek , linux-leds@vger.kernel.org, kernel@pengutronix.de, Thorsten Schmelzer Subject: Re: [PATCH] leds: led-class: detect brightness conversion base from string Message-ID: <20260310092319.GF183676@google.com> References: <20260123-leds-class-convert-brightness-value-v1-1-ae9d3ae4224b@pengutronix.de> <20260306113221.GI183676@google.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, 06 Mar 2026, Andy Shevchenko wrote: > On Fri, Mar 06, 2026 at 11:32:21AM +0000, Lee Jones wrote: > > On Thu, 05 Mar 2026, Andy Shevchenko wrote: > > > On Fri, Jan 23, 2026 at 10:57:26AM +0100, Michael Tretter wrote: > > > > From: Thorsten Schmelzer > > > > > > > > sysfs-class-led doesn't specify the number format for the brightness, > > > > but the class only accepts base 10 numbers. > > > > > > > > Use the automatic base detection of kstrtoul and accept the brightness > > > > as hex value as well. > > > > > > This obviously brings a regression. > > > Previously the 000000000000100 is 100, now it's 64. > > > > > > While I don't care much (I even like the change), I have to point this out. > > > > > > The correct fix is to update documentation. > > > > Again, should we remove this patch that you like? > > Depends if anybody outside relies on the above mentioned decimal values > with leading 0(s). On the safest side is better to drop (and explain in > the documentation that the values are decimal). For the fear of breaking userspace, I have dropped the patch. Please could someone update the docs? -- Lee Jones [李琼斯]