From: Lee Jones <lee@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Pavel Machek <pavel@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Fall back to using software node name as LED name
Date: Wed, 25 Mar 2026 13:38:36 +0000 [thread overview]
Message-ID: <20260325133836.GB1141718@google.com> (raw)
In-Reply-To: <20260311-led-swnode-name-v1-0-798a49e041c6@gmail.com>
On Wed, 11 Mar 2026, Dmitry Torokhov wrote:
> This allows setting just name in software node representing an LED
> instance and forego "label" or other properties needed to form a name.
> This is helpful when converting old boards using bespoke platform data
> to software nodes/static device properties.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> Dmitry Torokhov (2):
> leds: core: implement fallback to software node name for LED names
> leds: core: fix formatting issues
>
> drivers/leds/led-core.c | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
> ---
> base-commit: 7109a2155340cc7b21f27e832ece6df03592f2e8
> change-id: 20260311-led-swnode-name-6db2e5757071
I'm happy with the set, but it failed to apply to leds-next.
diff a/drivers/leds/led-core.c b/drivers/leds/led-core.c (rejected hunks)
@@ -584,8 +582,9 @@ int led_compose_name(struct device *dev, struct led_init_data *init_data,
} else if (is_software_node(fwnode)) {
n = snprintf(led_classdev_name, LED_MAX_NAME_SIZE, "%s",
fwnode_get_name(fwnode));
- } else
+ } else {
return -EINVAL;
+ }
if (n >= LED_MAX_NAME_SIZE)
return -E2BIG;
Please rebase and [RESEND].
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2026-03-25 13:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 1:43 [PATCH 0/2] Fall back to using software node name as LED name Dmitry Torokhov
2026-03-12 1:43 ` [PATCH 1/2] leds: core: implement fallback to software node name for LED names Dmitry Torokhov
2026-03-12 1:43 ` [PATCH 2/2] leds: core: fix formatting issues Dmitry Torokhov
2026-03-26 9:32 ` (subset) " Lee Jones
2026-03-25 13:38 ` Lee Jones [this message]
2026-03-25 16:07 ` [PATCH 0/2] Fall back to using software node name as LED name Dmitry Torokhov
2026-03-26 9:32 ` Lee Jones
2026-03-26 9:32 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325133836.GB1141718@google.com \
--to=lee@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox