From: Lee Jones <lee@kernel.org>
To: Manuel Fombuena <fombuena@outlook.com>
Cc: pavel@kernel.org, vicentiu.galanopulo@remote-tech.co.uk,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/9] leds: st1202: fix multiple bugs in pattern engine and brightness handling
Date: Wed, 17 Jun 2026 16:04:55 +0100 [thread overview]
Message-ID: <20260617150455.GK10056@google.com> (raw)
In-Reply-To: <GV1PR08MB849762937DA5B82DC89F1CC4C5112@GV1PR08MB8497.eurprd08.prod.outlook.com>
On Fri, 05 Jun 2026, Manuel Fombuena wrote:
> This series fixes several bugs in the LED1202 driver related to hardware
> pattern programming and brightness control. The issues were found during
> testing on a Linksys MX4200v2 router running OpenWrt.
I was going to comment on each patch, but here, take the whole review:
https://sashiko.dev/#/patchset/GV1PR08MB84976729EED25ECB484835A4C5112@GV1PR08MB8497.eurprd08.prod.outlook.com
=:-)
--
Lee Jones
prev parent reply other threads:[~2026-06-17 15:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 13:59 [PATCH v3 0/9] leds: st1202: fix multiple bugs in pattern engine and brightness handling Manuel Fombuena
2026-06-05 14:03 ` [PATCH v3 1/9] leds: st1202: stop pattern sequence before reprogramming Manuel Fombuena
2026-06-17 15:04 ` Lee Jones
2026-06-05 14:04 ` [PATCH v3 2/9] leds: st1202: validate pattern input before stopping the sequence Manuel Fombuena
2026-06-05 14:06 ` [PATCH v3 3/9] leds: st1202: fix pattern duration prescaler and pattern_clear skip marker Manuel Fombuena
2026-06-05 14:07 ` [PATCH v3 4/9] leds: st1202: restore Pattern0 PWM to full on after clearing pattern Manuel Fombuena
2026-06-05 14:08 ` [PATCH v3 5/9] leds: st1202: fix spurious pattern sequence start in setup Manuel Fombuena
2026-06-05 14:09 ` [PATCH v3 6/9] leds: st1202: fix brightness having no effect while pattern mode is active Manuel Fombuena
2026-06-05 14:10 ` [PATCH v3 7/9] leds: st1202: disable channel when brightness is set to zero Manuel Fombuena
2026-06-05 14:11 ` [PATCH v3 8/9] leds: st1202: validate LED reg property against channel count Manuel Fombuena
2026-06-05 14:12 ` [PATCH v3 9/9] leds: st1202: correct and extend hw_pattern documentation Manuel Fombuena
2026-06-17 15:04 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260617150455.GK10056@google.com \
--to=lee@kernel.org \
--cc=fombuena@outlook.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=vicentiu.galanopulo@remote-tech.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox