From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCC6540B363; Mon, 13 Jul 2026 16:34:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783960494; cv=none; b=LMvkzmwqCNX4QLdcpTJqYgRu66urAiROoD1B4x2hS7qCIYaCu2quN7Zp+CHThNMtV0ZXkaT+4GwxUVTvNfBsylW6SjHeQlnkORoVwLez5Ceu+GCqH4+5d3Kp2WdSe7MP+C5aYQBaf+8RKmM44Yly85+gkphjARofVQDW1yIv3bs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783960494; c=relaxed/simple; bh=na1uv642ZQrq6gWKyzyjjyTGH+8BPshBveflTbSNjgc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ut7WUrm0OPAs9l47vgdCHmhixLcbELpRCLFWVFisMgnILUIGmJw2ZBcEKBUUIEC2Wsh72ipwZCeMjuYL+xjZQ3zABdexIYkPgEvM1wGvOykiL7c8eUJURUQGTr/GLSaNP8nNpcLgalP920QeO50KoQJdqfwlaf8P/9hyUnVZJMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YGA9ko4V; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YGA9ko4V" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77E381F000E9; Mon, 13 Jul 2026 16:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783960493; bh=TWl2pjBXORo/TSKlw37Ir+gVF0UuTAmSudez331KOlI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=YGA9ko4VvaxB54Kl5hgoPWXgOPl/vRN7Vrr+YCZk2VGNJrdPWqXVcQfR7xRWbx/YJ N/EvAm8bc8pXArHcwmHQuF9mHNHIAEggf9WUZqJ3lhLqwmjo3xiPppQ2RmeFhfbpXe P/kyduGapmN2Nv3ij8Ni7BLCgDlwKztdI3bRR4CXOttZznIpN+PqrScKHSNdwEW+HW U5an22ptcH9WeEb4Y6c8bxEHf7MclBCKD5yAPG4P5Y0XuFRVRy1wwYf9gwnkY91se6 GQ6eOH1U1AtKxIeVAV5kccdbKWVyJ+nNSzI6MjLHgDm2XRm6IKaMVIAwauhQWDLNps FubqAP1mP6Owg== Date: Mon, 13 Jul 2026 17:34:49 +0100 From: Conor Dooley To: Jonas Rebmann Cc: Stefan Wahren , Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jean-Jacques Hiblot , linux-leds@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH RFC 1/2] dt-bindings: leds-group-multicolor: Introduce default-intensity Message-ID: <20260713-undercoat-cranium-c018ab9ab642@spud> References: <20260708224652.106632-1-wahrenst@gmx.net> <20260708224652.106632-2-wahrenst@gmx.net> <20260709-outsell-undamaged-6c8045d6115f@spud> <0e3f38bd-ca70-4136-a313-564267cb9239@pengutronix.de> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Q2L6aTL7M8Oj44P9" Content-Disposition: inline In-Reply-To: <0e3f38bd-ca70-4136-a313-564267cb9239@pengutronix.de> --Q2L6aTL7M8Oj44P9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 13, 2026 at 10:41:53AM +0200, Jonas Rebmann wrote: > Hi Stefan, >=20 > Thanks, for CCing me here. >=20 > On 2026-07-13 10:23, Stefan Wahren wrote: > > sorry, I missed this. Thanks for pointing to this patch. In general i'm > > fine with this approach, but there is something which confuses me. > > Looking at the description, there is the statement: [default-intensity] > > "Defaults to 0". > > This seems to be correct for the Linux implementation of > > leds-pwm-multicolor, but is this really an expectation along all (multi > > color) LEDs (at least for Linux)? >=20 > You are right, sadly the initialization default of some > multicolor-LED drivers differs. Hmm, I forget if you had a default in leds common.yaml, but you should probably remove it in this case and move the default to the individual led type if so, rather than wait for support in a driver that doesn't zero initialise. > > E.g. leds-group-multicolor init the intensity with the maximum. So all > > users of leds-group-multicolor should specify default-intensity for each > > sub LED to achieve a defined behavior without breaking existing behavio= r. >=20 > I agree, once support is added to one of the drivers that doesn't > zero-initialize, the documentation needs updating (because as you say, > backwards-compatibilty probably beats consistency here). >=20 > I'm also just noticing that my v3 for only the dt-bindings never arrived > on the list (I think I was on a buggy b4 master), I'll re-send now. >=20 > Regards, > Jonas >=20 > --=20 > Pengutronix e.K. | Jonas Rebmann | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | --Q2L6aTL7M8Oj44P9 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCalUTqQAKCRB4tDGHoIJi 0uA4AQDJIJjUl6dzr6MOLQnkT46rw8z86SUQrrxPm5vvDLjjYwEA9Nsu5J/eXBE1 vJ5Lm5GFrwZVWh/6D991825lwxncngA= =NFPt -----END PGP SIGNATURE----- --Q2L6aTL7M8Oj44P9--