From: Ninad Naik <ninadnaik07@gmail.com>
To: lee@kernel.org, pavel@kernel.org, william.zhang@broadcom.com,
anand.gore@broadcom.com, kursad.oney@broadcom.com,
florian.fainelli@broadcom.com, rafal@milecki.pl,
linux@weissschuh.net, krzysztof.kozlowski@oss.qualcomm.com,
tzungbi@kernel.org
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
me@brighamcampbell.com, Ninad Naik <ninadnaik07@gmail.com>
Subject: [PATCH] leds: bcm63138: Use %pe to print pinctrl error instead of %ld
Date: Tue, 14 Jul 2026 01:37:32 +0530 [thread overview]
Message-ID: <20260713200732.2470666-1-ninadnaik07@gmail.com> (raw)
Pass the pinctrl error pointer directly to %pe to print the
symbolic error name.
Detected by Coccinelle. Tested by compiling.
Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
---
drivers/leds/blink/leds-bcm63138.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/blink/leds-bcm63138.c b/drivers/leds/blink/leds-bcm63138.c
index 45c0662df933..12b70ee31b9a 100644
--- a/drivers/leds/blink/leds-bcm63138.c
+++ b/drivers/leds/blink/leds-bcm63138.c
@@ -236,8 +236,8 @@ static void bcm63138_leds_create_led(struct bcm63138_leds *leds,
pinctrl = devm_pinctrl_get_select_default(led->cdev.dev);
if (IS_ERR(pinctrl) && PTR_ERR(pinctrl) != -ENODEV) {
- dev_warn(led->cdev.dev, "Failed to select %pOF pinctrl: %ld\n",
- np, PTR_ERR(pinctrl));
+ dev_warn(led->cdev.dev, "Failed to select %pOF pinctrl: %pe\n",
+ np, pinctrl);
}
bit = BIT(led->pin);
--
2.55.0
next reply other threads:[~2026-07-13 20:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 20:07 Ninad Naik [this message]
2026-07-13 20:15 ` [PATCH] leds: bcm63138: Use %pe to print pinctrl error instead of %ld sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713200732.2470666-1-ninadnaik07@gmail.com \
--to=ninadnaik07@gmail.com \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=kursad.oney@broadcom.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=me@brighamcampbell.com \
--cc=pavel@kernel.org \
--cc=rafal@milecki.pl \
--cc=skhan@linuxfoundation.org \
--cc=tzungbi@kernel.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox