From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B249305680; Wed, 15 Jul 2026 13:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784123517; cv=none; b=lw3sjWp2CCW8m9IGfY/V+FLDc6jTJY0HVs4BF7dnqRPMMTscuxVTLwF71HJc4rvh+QbRfMUjkA8YfWMeuR4cmQa56MsM0+r3ksmazRUJ6NyGtzvW629IVdgNPoQreVsEuM8gSUq3rLrlFo6/ha5jIjk/Y1h9aNY3BdIo1V2go4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784123517; c=relaxed/simple; bh=/aKDa2kaqUVRk9ufeRGSTFGuljIVmQiABhfBmKVd91I=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=E1oOrU6CGhVwK3/W3dezChGQelLuvVIf03nuaRirUvofvXWi539JJ991F0owERHKxCsyqBmtW6poJxpD5WxBvQ7vrAJInKZcArOF7d3LViEDnpZFeELKWazfdmoRSEzNDKbAH4y1p52l4zE4v5dexsWVursia0r/PniT06F2Fw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oyal3+F6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oyal3+F6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5C311F000E9; Wed, 15 Jul 2026 13:51:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784123516; bh=hZoF7RerIR03yZN4MonDtp4YtuKsc+TsPXE0SJkdkUE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=oyal3+F6tj/+ZlA9CIbnH+YxbMnHHyabmXQYG4oBfPbFwnfWq6zwO9Zh64mLTIYCE eq0WjjsopygRa00PIyDK4mPgrosr6wTUytmKJpBALTlqS6neK7sq//Q8Pqh/DoCo7g CTDDOcdeS0zHyNx6sasrGuFnJWZzx5hfdLY+3U9kL8Lfb6XQWDRii4eCOVpB8PHerC +7uYkoMPTQtX+U5XBLCV/STi/oFodN/LrfY0aThOYjdnOtPtBxoypRRzQZws8gDWdZ igsskStsQpcZgDrweEjvzXtS1vUcfEDUyCOlbMg3+aEvnsJ+wl4osrtEoFLqzw1XBq g8nMQk6Gh270Q== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635 Reply-To: sashiko-reviews@lists.linux.dev To: "Loic Poulain" Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, linux-leds@vger.kernel.org, lee@kernel.org In-Reply-To: <20260715-monza-leds-v6-1-d1724bb7fe3d@oss.qualcomm.com> References: <20260715-monza-leds-v6-0-d1724bb7fe3d@oss.qualcomm.com> <20260715-monza-leds-v6-1-d1724bb7fe3d@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 15 Jul 2026 13:51:55 +0000 Message-Id: <20260715135155.E5C311F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The commit message claims to tighten the node name regex from `[= 0-9a-f]+` to `[0-9a-f]` to match the single-digit hardware limit. However, = this change was only applied to the top-level `patternProperties`. The corr= esponding regexes inside the `allOf` conditional blocks for older chip gene= rations were neglected and still allow multiple hex digits. -- --- Patch [1]: [PATCH v6 1/4] dt-bindings: leds: nxp,pca963x: fix reg maxim= um for pca9635 --- commit a500d493e0680c38dffc3b668e4fe9888ec4d0bd Author: Loic Poulain Subject: dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635 This commit increases the maximum reg value to 15 in the top-level led node to support 16 channels on the pca9635. It refactors the allOf conditionals to give pca9634 its own block and changes the top-level regex constraint to match a single hexadecimal digit. > diff --git a/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml b/Do= cumentation/devicetree/bindings/leds/nxp,pca963x.yaml > index 938d0e48fe51b..4fda602912f7a 100644 > --- a/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml > +++ b/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml [ ... ] > @@ -88,7 +88,13 @@ allOf: > properties: > reg: > maximum: 3 > - else: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - nxp,pca9634 > + then: > patternProperties: > "^led@[0-9a-f]+$": [Severity: Medium] The commit message states the regex is tightened to single-digit [0-9a-f], but is it intentional that the patternProperties inside the allOf blocks for older generations still use the multiple-digit [0-9a-f]+ pattern? While the top-level constraint handles the validation correctly, retaining the '+' in the nested conditional blocks for pca9634 (and the pca9632 and pca9633 block just above this hunk) leaves the schema internally inconsistent with the stated intent. > properties: > reg: --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260715-monza-leds= -v6-0-d1724bb7fe3d@oss.qualcomm.com?part=3D1