From: Arunachalam <arun07172003@gmail.com>
To: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>
Cc: Andreas Werner <andreas.werner@men.de>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Arunachalam <arun07172003@gmail.com>
Subject: [PATCH 3/4] leds: menf21bmc: convert to dev_err_probe()
Date: Thu, 16 Jul 2026 23:52:47 +0530 [thread overview]
Message-ID: <20260716182247.9449-1-arun07172003@gmail.com> (raw)
Replace open-coded dev_err() + return pattern with dev_err_probe(),
which also handles -EPROBE_DEFER correctly.
Signed-off-by: Arunachalam <arun07172003@gmail.com>
---
drivers/leds/leds-menf21bmc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/leds/leds-menf21bmc.c b/drivers/leds/leds-menf21bmc.c
index 6b1b47160..a7e4db487 100644
--- a/drivers/leds/leds-menf21bmc.c
+++ b/drivers/leds/leds-menf21bmc.c
@@ -84,10 +84,8 @@ static int menf21bmc_led_probe(struct platform_device *pdev)
leds[i].cdev.brightness_set = menf21bmc_led_set;
leds[i].i2c_client = i2c_client;
ret = devm_led_classdev_register(&pdev->dev, &leds[i].cdev);
- if (ret < 0) {
- dev_err(&pdev->dev, "failed to register LED device\n");
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(&pdev->dev, ret, "failed to register LED device\n");
}
dev_info(&pdev->dev, "MEN 140F21P00 BMC LED device enabled\n");
--
2.39.5
reply other threads:[~2026-07-16 18:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716182247.9449-1-arun07172003@gmail.com \
--to=arun07172003@gmail.com \
--cc=andreas.werner@men.de \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox