From: kr494167@gmail.com
To: lee@kernel.org, pavel@kernel.org
Cc: kauschluss@disroot.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, surendra <kr494167@gmail.com>
Subject: [PATCH 2/2] leds: flash: s2m: wire up of_match_table in platform driver
Date: Tue, 21 Jul 2026 11:18:46 +0530 [thread overview]
Message-ID: <20260721054846.34318-3-kr494167@gmail.com> (raw)
In-Reply-To: <20260721054846.34318-1-kr494167@gmail.com>
From: surendra <kr494167@gmail.com>
The driver defines and registers s2m_fled_of_match_table via
MODULE_DEVICE_TABLE(of, ...) but never assigns it to the platform
driver's .of_match_table field. As a result the kernel never matches
this driver against a DT node with compatible "samsung,s2mu005-flash",
making the MODULE_DEVICE_TABLE entry dead code.
Wire the table up so that DT-based probing and module auto-loading
work as intended.
Fixes: 02149db273a9 ("leds: flash: Add support for Samsung S2M series PMIC flash LED device")
Signed-off-by: surendra <kr494167@gmail.com>
---
drivers/leds/flash/leds-s2m-flash.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/flash/leds-s2m-flash.c b/drivers/leds/flash/leds-s2m-flash.c
index 6ee8db094611..2373a70d83eb 100644
--- a/drivers/leds/flash/leds-s2m-flash.c
+++ b/drivers/leds/flash/leds-s2m-flash.c
@@ -339,6 +339,7 @@ MODULE_DEVICE_TABLE(of, s2m_fled_of_match_table);
static struct platform_driver s2m_fled_driver = {
.driver = {
.name = "s2m-flash",
+ .of_match_table = s2m_fled_of_match_table,
},
.probe = s2m_fled_probe,
.id_table = s2m_fled_id_table,
--
2.55.0
next prev parent reply other threads:[~2026-07-21 5:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 5:48 [PATCH 0/2] leds: s2m: wire up missing of_match_table in platform drivers kr494167
2026-07-21 5:48 ` [PATCH 1/2] leds: rgb: s2m: wire up of_match_table in platform driver kr494167
2026-07-21 5:58 ` sashiko-bot
2026-07-21 5:48 ` kr494167 [this message]
2026-07-21 5:57 ` [PATCH 2/2] leds: flash: " sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721054846.34318-3-kr494167@gmail.com \
--to=kr494167@gmail.com \
--cc=kauschluss@disroot.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox