Re: [RFC net-next 2/4] leds: rgb: Add IS32FL3207 controller driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The i2c_device_id array is initialized without named initializers.
--

--- Patch [2]: [RFC net-next 2/4] leds: rgb: Add IS32FL3207 controller driver ---
commit 2f0ef1606e8fe9f37cd22e9360f765264557dd4d
Author: Ahmad Byagowi <ahmadexp@gmail.com>

leds: rgb: Add IS32FL3207 controller driver

This commit adds a generic I2C driver for the Lumissil IS32FL3207 18-channel
LED controller. It exposes individual and multicolor LEDs through the LED
class, handling optional supply and enable GPIO.

> diff --git a/drivers/leds/rgb/leds-is32fl3207.c b/drivers/leds/rgb/leds-is32fl3207.c
> new file mode 100644
> index 0000000000000..8f04534644dce
> --- /dev/null
> +++ b/drivers/leds/rgb/leds-is32fl3207.c
[ ... ]
> +static const struct of_device_id is32fl3207_of_match[] = {
> +	{ .compatible = "issi,is32fl3207" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, is32fl3207_of_match);
> +
> +static const struct i2c_device_id is32fl3207_id[] = {
> +	{ "is32fl3207" },

[Severity: Low]
This isn't a bug, but should this array use a named initializer 
(e.g., { .name = "is32fl3207" })? The I2C subsystem guidelines request 
that initialized arrays of type struct i2c_device_id use named initializers.

> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, is32fl3207_id);
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1785684064.git.ahmadexp@gmail.com?part=2