Linux LED subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ahmad Byagowi" <ahmadexp@gmail.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org, robh@kernel.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [RFC net-next v2 5/6] ptp: ocp: Add R4006 I2C peripheral topology
Date: Tue, 04 Aug 2026 20:50:54 +0000	[thread overview]
Message-ID: <20260804205055.67FC01F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260803205011.1249-6-ahmadexp@gmail.com>

> R4006 cards place a PCA9546 mux behind the FPGA I2C controller. The mux
> exposes three LM75B temperature sensors, an SHT3x humidity sensor, an
> ICP10100 pressure sensor, and an IS32FL3207 controller for the GNSS and
> SMA LEDs.
> 
> Describe the per-card topology with software nodes and instantiate
> standard I2C clients after their adapters appear. Use a reusable board
> profile selected only when the validated EEPROM ID begins with "R4006".
> PCI IDs are shared by multiple PCB revisions and cannot safely select
> LED wiring.
> 
> Leave the channel containing the BNO08x empty because no upstream driver
> exists. Retry asynchronous population with a bounded budget. Serialize
> population against controller and mux driver bind/unbind, remove the mux
> when the root adapter disappears, and support adapter reappearance. Limit
> the existing i2c sysfs link to the root adapter.
> 
> Signed-off-by: Ahmad Byagowi <ahmadexp@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260803205011.1249-1-ahmadexp@gmail.com?part=5


  reply	other threads:[~2026-08-04 20:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 20:50 [RFC net-next v2 0/6] ptp: ocp: Add R4006 and V9 I2C peripheral support Ahmad Byagowi
2026-08-03 20:50 ` [RFC net-next v2 1/6] dt-bindings: leds: Add IS32FL3207 controller Ahmad Byagowi
2026-08-04 20:50   ` sashiko-bot
2026-08-03 20:50 ` [RFC net-next v2 2/6] leds: rgb: Add IS32FL3207 controller driver Ahmad Byagowi
2026-08-04 20:50   ` sashiko-bot
2026-08-03 20:50 ` [RFC net-next v2 3/6] i2c: mux: Propagate software nodes to channel adapters Ahmad Byagowi
2026-08-04 20:51   ` sashiko-bot
2026-08-03 20:50 ` [RFC net-next v2 4/6] ptp: ocp: Validate EEPROM board IDs Ahmad Byagowi
2026-08-04 13:55   ` Vadim Fedorenko
2026-08-04 21:07     ` Ahmad Byagowi
2026-08-04 20:50   ` sashiko-bot
2026-08-03 20:50 ` [RFC net-next v2 5/6] ptp: ocp: Add R4006 I2C peripheral topology Ahmad Byagowi
2026-08-04 20:50   ` sashiko-bot [this message]
2026-08-03 20:50 ` [RFC net-next v2 6/6] ptp: ocp: Add Time Card V9 " Ahmad Byagowi
2026-08-04 20:51   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804205055.67FC01F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=ahmadexp@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox