Re: [PATCH 2/7] dt-bindings: leds: pca995x: describe output-gain property

[Krzysztof Kozlowski <krzk@kernel.org>]

On Wed, Sep 02, 2026 at 03:10:09PM +0200, Nora Schiffer wrote:
> On Wed, 2026-09-02 at 12:31 +0000, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
> > - [Low] The custom, device-specific property `output-gain` lacks a mandatory vendor prefix.
> 
> Probably makes sense to add the vendor prefix, will do in v2.
> 
> > - [Low] The `output-gain` property incorrectly exposes a raw hardware register value directly to the Device Tree instead of describing physical units.
> 
> According to the datasheet, the LED current is calculated as follows:
> 
>     Iled = output_gain * 900mV / Rext / 4
> 
> If we want to fully describe the output gain using physical units, something
> like output-current-microamps and external-resistor-ohms would work. There
> wouldn't be a meaningful default for these properties to describe in the binding
> docs however, which is possible for "output-gain" (as the driver just sets that
> to 127.)

Output current is already there, no? led-max-microamp? So basically you
would be re-describing it... although I understand that for your case
you need two properties (also the resistor) to calculate the value to program.

Best regards,
Krzysztof