Linux LED subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Rosen Penev" <rosenp@gmail.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH] leds: syscon: Use device property API
Date: Mon, 07 Sep 2026 20:30:39 +0000	[thread overview]
Message-ID: <20260907203039.DBA081F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260907202436.42304-1-rosenp@gmail.com>

> Replace the DT-specific of_property_read_u32() calls and the
> dev_of_node()/of_fwnode_handle() roundtrip with their
> device/fwnode equivalents. Behaviour is unchanged for device
> tree: device_property_read_u32() and dev_fwnode() operate on the
> same node, and the fallback from "reg" to "offset" is preserved.
> 
> Use dev_fwnode() for init_data.fwnode; unlike a child node from
> a scoped iterator, the platform device's own node is held by the
> driver core for the device lifetime.
> 
> Assisted-by: opencode:deepseek-v4-flash-free
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907202436.42304-1-rosenp@gmail.com?part=1


  reply	other threads:[~2026-09-07 20:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07 20:24 [PATCH] leds: syscon: Use device property API Rosen Penev
2026-09-07 20:30 ` sashiko-bot [this message]
2026-09-17 14:04 ` (subset) " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907203039.DBA081F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=rosenp@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox