Re: [PATCH] leds: lp8860: fix device_node leak in lp8860_probe()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The enable_gpio is initialized to logical low and never asserted, leaving the device permanently disabled.
--

commit fc2187284635f3278f3bb6af71e6925402976134
Author: Miles Krause <mileskrause5200@gmail.com>

leds: lp8860: fix device_node leak in lp8860_probe()

This commit fixes a device_node leak in lp8860_probe() by using the
__free(device_node) cleanup helper. It drops the manual management of
the reference returned by of_get_next_available_child().

> diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c
> index 69f064781f699..f6e4227de903a 100644
> --- a/drivers/leds/leds-lp8860.c
> +++ b/drivers/leds/leds-lp8860.c
[ ... ]
> @@ -282,7 +282,8 @@ static int lp8860_probe(struct i2c_client *client)
>  	if (!led)
>  		return -ENOMEM;
>  
> -	child_node = of_get_next_available_child(np, NULL);
> +	struct device_node *child_node __free(device_node) =
> +		of_get_next_available_child(np, NULL);
>  	if (!child_node)
>  		return -EINVAL;
>  

[Severity: High]
This isn't a bug introduced by this patch, but this is a pre-existing 
issue in lp8860_probe(). Immediately following this lookup:

drivers/leds/leds-lp8860.c:lp8860_probe() {
    ...
    enable_gpio = devm_gpiod_get_optional(&client->dev, "enable", GPIOD_OUT_LOW);
    ...
}

Does initializing the enable GPIO to logical low (GPIOD_OUT_LOW) leave the 
device permanently disabled? The driver never seems to assert the GPIO to 
high to enable the chip. 

Other sibling drivers appear to correctly initialize their enable GPIO with
GPIOD_OUT_HIGH.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-leds-lp8860-of-node-leak-v1-1-d333cff4345b@gmail.com?part=1