From: sashiko-bot@kernel.org
To: "Cong Nguyen" <congnt264@gmail.com>
Cc: lee@kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: lm3692x: fix regulator/gpio leak and wrong enabled state on last write failure
Date: Tue, 15 Sep 2026 03:52:32 +0000 [thread overview]
Message-ID: <20260915035232.C78811F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915034515.4147981-1-congnt264@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] leds: commit message description is not capitalized
--
commit b25c5a499c39fb9de3dfd21fd5b2889e97d97b83
Author: Cong Nguyen <congnt264@gmail.com>
leds: lm3692x: fix regulator/gpio leak and wrong enabled state on last write failure
This commit addresses an error handling omission in lm3692x_leds_enable(), where
the final write ignores its return value and marks the LED as enabled even on
failure. Routing this through the standard error path prevents regulator leaks
and ensures proper retry behavior.
> leds: lm3692x: fix regulator/gpio leak and wrong enabled state on last write failure
[Severity: Low]
This isn't a bug, but does the commit subject violate the LED subsystem
convention for capitalization? The subsystem guidelines require capitalizing
the description after the prefix (e.g., "leds: lm3692x: Fix regulator...").
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915034515.4147981-1-congnt264@gmail.com?part=1
next prev parent reply other threads:[~2026-09-15 3:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 3:45 [PATCH] leds: lm3692x: fix regulator/gpio leak and wrong enabled state on last write failure Cong Nguyen
2026-09-15 3:52 ` sashiko-bot [this message]
2026-09-22 12:48 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915035232.C78811F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=congnt264@gmail.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox