Re: [PATCH v2 05/13] leds: st1202: Clear unused pattern slots in pattern_set()

[sashiko-bot@kernel.org]

> The pattern duration registers are chip-wide while the PWM registers are
> per-channel, so a channel can end up driven by a sequencer timeline it
> never programmed.
> 
> st1202_led_pattern_set() programs only the first len slots. The pattern
> trigger calls pattern_clear() before pattern_set() only once a channel is
> already in PATTERN_TYPE_HW mode, and activating the trigger resets that
> mode, so the first hardware pattern written after every activation skips
> it. If another channel has already programmed a longer pattern,
> durations [len, 8) are still set, and this channel's PWM for those slots
> holds whatever was last written there.
> 
> That used to be LED_OFF, so a channel stayed dark for the slots it had
> not programmed itself. Since commit d2ca0e2b6d64 ("leds: st1202: Set all
> pattern PWM slots to full after clearing pattern") pattern_clear() leaves
> [ ... ]
> from having a single hardware sequencer and is not something this can
> correct.
> 
> Fixes: d2ca0e2b6d64 ("leds: st1202: Set all pattern PWM slots to full after clearing pattern")
> Signed-off-by: Manuel Fombuena <fombuena@outlook.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/GV1PR08MB8497668D389D43F680D2CE3CC5BA2@GV1PR08MB8497.eurprd08.prod.outlook.com?part=5