Linux LED subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Dmitry Antipov" <dmantipov@yandex.ru>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH v3 2/2] leds: flash: Simplify flash_fault_show()
Date: Wed, 16 Sep 2026 16:22:54 +0000	[thread overview]
Message-ID: <20260916162255.4E3D71F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260916161607.90106-2-dmantipov@yandex.ru>

> Do not emit extra trailing space and use sysfs_emit_at()
> over sprintf()/strcat()/strlen() in flash_fault_show().
> 
> Suggested-by: Lee Jones <lee@kernel.org>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916161607.90106-1-dmantipov@yandex.ru?part=2


  reply	other threads:[~2026-09-16 16:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 16:16 [PATCH v3 1/2] leds: flash: Prevent using uninitialized variable in flash_fault_show() Dmitry Antipov
2026-09-16 16:16 ` [PATCH v3 2/2] leds: flash: Simplify flash_fault_show() Dmitry Antipov
2026-09-16 16:22   ` sashiko-bot [this message]
2026-09-16 16:25 ` [PATCH v3 1/2] leds: flash: Prevent using uninitialized variable in flash_fault_show() sashiko-bot
2026-09-22 13:27 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916162255.4E3D71F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dmantipov@yandex.ru \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox