From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH] leds: netxbig: Fix platform device reference leak on successful probe
Date: Thu, 17 Sep 2026 09:42:24 +0000 [thread overview]
Message-ID: <20260917094224.80E7A1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917093641.2144866-1-vulab@iscas.ac.cn>
> of_find_device_by_node() returns the GPIO extension device with an
> elevated reference count. The error paths release it through the
> put_device label, but the success path returns directly, so the
> reference is leaked whenever the LED driver probes successfully.
>
> Let the success path fall through to the put_device label.
>
> Fixes: 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917093641.2144866-1-vulab@iscas.ac.cn?part=1
next prev parent reply other threads:[~2026-09-17 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 9:36 [PATCH] leds: netxbig: Fix platform device reference leak on successful probe Wentao Liang
2026-09-17 9:42 ` sashiko-bot [this message]
2026-09-22 16:03 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917094224.80E7A1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox