From: sashiko-bot@kernel.org
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH] leds: use assign_bit() where applicable
Date: Fri, 18 Sep 2026 14:26:02 +0000 [thread overview]
Message-ID: <20260918142602.922E41F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260918141728.3022983-1-peng.fan@oss.nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] leds: commit message description is not capitalized
--
commit 4b1968fcc8204102041e265576cd6e2a93a963a3
Author: Peng Fan <peng.fan@nxp.com>
leds: use assign_bit() where applicable
This commit converts open-coded if/else sequences using set_bit and
clear_bit variants to the unified assign_bit API using Coccinelle.
> leds: use assign_bit() where applicable
[Severity: Low]
This isn't a bug, but the commit message description after the
subsystem prefix is not capitalized. According to the LED subsystem
guidelines, it should start with a capital letter.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260918141728.3022983-1-peng.fan@oss.nxp.com?part=1
next prev parent reply other threads:[~2026-09-18 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 14:17 [PATCH] leds: use assign_bit() where applicable Peng Fan (OSS)
2026-09-18 14:26 ` sashiko-bot [this message]
2026-09-23 15:17 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918142602.922E41F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=peng.fan@oss.nxp.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox