Re: [RFC PATCH] leds: trigger: netdev: Support devices in other network namespaces

[sashiko-bot@kernel.org]

> The netdev LED trigger currently cannot resolve a network device that
> has been moved into another network namespace.
> 
> For example:
> 
>   ip link add vm1 type veth peer vm2
>   tools/leds/uledmon test:green:netdev &
> 
>   echo netdev > /sys/class/leds/test:green:netdev/trigger
>   echo 1 > /sys/class/leds/test:green:netdev/link
> 
>   ip netns add ledns
>   ip link set vm2 netns ledns
>   ip netns exec ledns \
>           sh -c 'echo vm2 > /sys/class/leds/test:green:netdev/device_name'
> [ ... ]
> global LED sysfs interface, which is not network namespace aware. The
> namespace is therefore effectively selected by the task that last wrote
> device_name.
> 
> Signed-off-by: Marcus Flyckt <marcus.flyckt@kvaser.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928135130.1131749-1-marcus.flyckt@kvaser.com?part=1