Re: [PATCH v2 2/2] leds: trigger: input-events: Restore previous brightness on input

[sashiko-bot@kernel.org]

> From: Nikolay Plastinin <plaztininikolai@gmail.com>
> 
> The trigger turns the LEDs back on with LED_FULL, which the LED core
> clamps to max_brightness. For keyboard backlights with several levels,
> such as asus::kbd_backlight, this means the backlight always comes back
> at maximum after being idle instead of at the level the user picked.
> 
> Remember the brightness per LED before turning it off and restore it on
> the next input event. The level is kept in a small per-LED state struct
> allocated in activate() and freed in deactivate(), so the trigger is
> converted from the simple trigger API to a regular trigger. Brightness
> changes made while the trigger is active, for example with the keyboard
> brightness hotkeys, are picked up too. The LEDs are walked with the new
> led_trigger_walk_leds() helper instead of the trigger touching
> trig->led_cdevs itself.
> 
> Tested on an ASUS ROG Flow X13 GV302XV: with the keyboard backlight at
> level 1, it now comes back at level 1 after going idle instead of at 3.
> A level changed with the brightness hotkeys while the trigger is active
> is restored after the next idle period as well.
> 
> Assisted-by: LLM
> Signed-off-by: Nikolay Plastinin <plaztininikolai@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-leds-input-events-brightness-v2-0-3948d3cddd83@gmail.com?part=2