From: sashiko-bot@kernel.org
To: "A. Sverdlin" <alexander.sverdlin@siemens.com>
Cc: lee@kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 3/4] leds: trigger: netdev: Fix sysfs_update_group() races
Date: Thu, 01 Oct 2026 13:22:44 +0000 [thread overview]
Message-ID: <20261001132245.6014E1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001131206.2513248-4-alexander.sverdlin@siemens.com>
> From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>
> The link_speed attribute group was listed in netdev_led_trigger.groups,
> so the LED core creates and destroys it via device_add_groups() /
> device_remove_groups() in led_trigger_set() (under trigger_lock), while
> the trigger also refreshes it with sysfs_update_group() from
> netdev_trig_notify() and device_name writes. With no shared lock this was
> observed as a sysfs splat when the trigger is re-armed during PHY link-up:
>
> sysfs: cannot create duplicate filename '...green:lan/link_10'
>
> CPU 0 (led_trigger_set) CPU 1 (linkwatch workqueue)
> ----------------------- ---------------------------
> activate():
> register_netdevice_notifier()
> [ ... ]
> store that takes that lock.
>
> Cc: stable@vger.kernel.org
> Fixes: 06cdca014eca ("leds: trigger: netdev: Display only supported link speed attribute")
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001131206.2513248-1-alexander.sverdlin@siemens.com?part=3
next prev parent reply other threads:[~2026-10-01 13:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 13:11 [PATCH v4 0/4] leds: trigger: netdev: fix sysfs_update_group() races A. Sverdlin
2026-10-01 13:12 ` [PATCH v4 1/4] leds: trigger: netdev: Put netdev on activate error path A. Sverdlin
2026-10-01 13:22 ` sashiko-bot
2026-10-01 13:12 ` [PATCH v4 2/4] leds: trigger: netdev: Access net_dev under trigger_data->lock in the worker A. Sverdlin
2026-10-01 13:20 ` sashiko-bot
2026-10-01 13:12 ` [PATCH v4 3/4] leds: trigger: netdev: Fix sysfs_update_group() races A. Sverdlin
2026-10-01 13:22 ` sashiko-bot [this message]
2026-10-01 13:12 ` [PATCH v4 4/4] leds: trigger: netdev: Serialize mode/interval stores with trigger lock A. Sverdlin
2026-10-01 13:20 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001132245.6014E1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexander.sverdlin@siemens.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox