From: sashiko-bot@kernel.org
To: "Wayne Ho" <wayneho219@gmail.com>
Cc: lee@kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Documentation: ABI: leds: Drop stale gpio trigger reference for inverted
Date: Mon, 05 Oct 2026 15:31:44 +0000 [thread overview]
Message-ID: <20261005153144.BE3031F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261005-docs-leds-abi-trigger-attrs-v2-1-c5f8970b1b42@gmail.com>
> The description of the inverted attribute says it is specific to the
> gpio and backlight triggers, but commit 4a11dbf04f31 ("leds: triggers:
> gpio: Rewrite to use trigger-sources") removed it from the gpio trigger,
> which now only provides desired_brightness. Only the backlight trigger
> creates the inverted attribute today.
>
> Drop the reference to the gpio trigger.
>
> Fixes: 4a11dbf04f31 ("leds: triggers: gpio: Rewrite to use trigger-sources")
> Signed-off-by: Wayne Ho <wayneho219@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261005-docs-leds-abi-trigger-attrs-v2-0-c5f8970b1b42@gmail.com?part=1
next prev parent reply other threads:[~2026-10-05 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 15:27 [PATCH v2 0/2] Documentation: ABI: leds: Document shared trigger attributes Wayne Ho
2026-10-05 15:27 ` [PATCH v2 1/2] Documentation: ABI: leds: Drop stale gpio trigger reference for inverted Wayne Ho
2026-10-05 15:31 ` sashiko-bot [this message]
2026-10-05 15:27 ` [PATCH v2 2/2] Documentation: ABI: leds: Document timer, heartbeat and activity attributes Wayne Ho
2026-10-05 15:33 ` sashiko-bot
2026-10-12 17:01 ` [PATCH v2 0/2] Documentation: ABI: leds: Document shared trigger attributes Griffin Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005153144.BE3031F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wayneho219@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox