From: sashiko-bot@kernel.org
To: "Rosen Penev" <rosenp@gmail.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH v2] leds: pca955x: drop platform data and allocate LEDs with the device
Date: Mon, 05 Oct 2026 20:15:35 +0000 [thread overview]
Message-ID: <20261005201536.5D1891F00893@smtp.kernel.org> (raw)
In-Reply-To: <20261005200906.188636-1-rosenp@gmail.com>
> struct pca955x_platform_data has been private to this driver since
> commit ed1f4b9676a8 ("leds: pca955x: add device tree support"), so
> nothing can pass it in through dev_get_platdata() and it only serves
> as an intermediate copy of the per-LED type, default state and fwnode.
> That copy is a full array of struct pca955x_led, the same runtime
> structure that struct pca955x already holds, so the data is stored
> twice.
>
> Remove the platform data and parse the child firmware nodes directly
> into pca955x->leds[]. Make leds[] a flexible array member so it is
> allocated together with struct pca955x. This removes three
> allocations and the num_leds sanity check, which could no longer
> fail.
>
> struct pca955x_led moves above struct pca955x, as a flexible array
> member needs the complete element type.
>
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261005200906.188636-1-rosenp@gmail.com?part=1
prev parent reply other threads:[~2026-10-05 20:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 20:09 [PATCH v2] leds: pca955x: drop platform data and allocate LEDs with the device Rosen Penev
2026-10-05 20:15 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005201536.5D1891F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rosenp@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox