[PATCH] dt-bindings: leds: Document "netdev" trigger

[PATCH] dt-bindings: leds: Document "netdev" trigger

[Marek Vasut]

Document the "netdev" trigger which is used to control LEDs by
network device activity.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Lee Jones <lee@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-leds@vger.kernel.org
---
 Documentation/devicetree/bindings/leds/common.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index 8a3c2398b10ce..bf9a101e4d420 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -113,6 +113,8 @@ properties:
             # LED indicates NAND memory activity (deprecated),
             # in new implementations use "mtd"
           - nand-disk
+            # LED indicates network activity
+          - netdev
             # No trigger assigned to the LED. This is the default mode
             # if trigger is absent
           - none
-- 
2.43.0

Re: [PATCH] dt-bindings: leds: Document "netdev" trigger

[Krzysztof Kozlowski]

On 05/07/2024 23:52, Marek Vasut wrote:
> Document the "netdev" trigger which is used to control LEDs by
> network device activity.

Instead, please propose a patch adding a comment there (in that place):
"# netdev - not accepted, please do not add it"

This is like fourth or fifth attempt.

https://lore.kernel.org/all/20230217230346.GA2217008-robh@kernel.org/


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: leds: Document "netdev" trigger

[Marek Vasut]

On 7/7/24 3:49 PM, Krzysztof Kozlowski wrote:
> On 05/07/2024 23:52, Marek Vasut wrote:
>> Document the "netdev" trigger which is used to control LEDs by
>> network device activity.
> 
> Instead, please propose a patch adding a comment there (in that place):
> "# netdev - not accepted, please do not add it"
> 
> This is like fourth or fifth attempt.
> 
> https://lore.kernel.org/all/20230217230346.GA2217008-robh@kernel.org/

There is a follow up to that discussion:

https://lore.kernel.org/all/20230221014413.GA780723-robh@kernel.org/

That netdev trigger is nothing new, there are existing DTs using that 
trigger in-tree going back to 2019, this is only documenting it.

So, shall I really add a comment or update the commit message ?

Re: [PATCH] dt-bindings: leds: Document "netdev" trigger

[Krzysztof Kozlowski]

On 07/07/2024 21:49, Marek Vasut wrote:
> On 7/7/24 3:49 PM, Krzysztof Kozlowski wrote:
>> On 05/07/2024 23:52, Marek Vasut wrote:
>>> Document the "netdev" trigger which is used to control LEDs by
>>> network device activity.
>>
>> Instead, please propose a patch adding a comment there (in that place):
>> "# netdev - not accepted, please do not add it"
>>
>> This is like fourth or fifth attempt.
>>
>> https://lore.kernel.org/all/20230217230346.GA2217008-robh@kernel.org/
> 
> There is a follow up to that discussion:
> 
> https://lore.kernel.org/all/20230221014413.GA780723-robh@kernel.org/
> 
> That netdev trigger is nothing new, there are existing DTs using that 
> trigger in-tree going back to 2019, this is only documenting it.
> 
> So, shall I really add a comment or update the commit message ?

I was not aware that discussion, so it seems commit will be fine, but
with updated message.

Thanks.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: leds: Document "netdev" trigger

[Marek Vasut]

On 7/8/24 8:18 AM, Krzysztof Kozlowski wrote:
> On 07/07/2024 21:49, Marek Vasut wrote:
>> On 7/7/24 3:49 PM, Krzysztof Kozlowski wrote:
>>> On 05/07/2024 23:52, Marek Vasut wrote:
>>>> Document the "netdev" trigger which is used to control LEDs by
>>>> network device activity.
>>>
>>> Instead, please propose a patch adding a comment there (in that place):
>>> "# netdev - not accepted, please do not add it"
>>>
>>> This is like fourth or fifth attempt.
>>>
>>> https://lore.kernel.org/all/20230217230346.GA2217008-robh@kernel.org/
>>
>> There is a follow up to that discussion:
>>
>> https://lore.kernel.org/all/20230221014413.GA780723-robh@kernel.org/
>>
>> That netdev trigger is nothing new, there are existing DTs using that
>> trigger in-tree going back to 2019, this is only documenting it.
>>
>> So, shall I really add a comment or update the commit message ?
> 
> I was not aware that discussion, so it seems commit will be fine, but
> with updated message.

V2 with slightly expanded commit message sent, thanks !