From: Krzysztof Kozlowski <krzk@kernel.org>
To: Thomas Richard <thomas.richard@bootlin.com>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
DanieleCleri@aaeon.eu, GaryWang@aaeon.com.tw
Subject: Re: [PATCH] leds: upboard: fix module alias
Date: Fri, 17 Oct 2025 11:03:02 +0200 [thread overview]
Message-ID: <256ccf82-f893-42da-890f-6e4494394cb7@kernel.org> (raw)
In-Reply-To: <690812a9-2f2c-4a88-b6fb-a3789e931d11@bootlin.com>
On 17/10/2025 11:00, Thomas Richard wrote:
> On 10/16/25 9:11 PM, Krzysztof Kozlowski wrote:
>> On 16/10/2025 15:28, Thomas Richard wrote:
>>> Fix module alias for auto-loading.
>>
>> Fix what exactly? It was a completely correct alias. Please describe
>> here bug (so WHY you are doing this) not what you are doing.
>
> The module alias does not match the cell name defined in the MFD driver,
Then this should be clearly explained.
Again: your commit msg should describe the bug, the reasons why you are
doing it, not just "fix" without telling what is wrong.
> so if the driver is built as a module, it is not automatically loaded.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-10-17 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 13:28 [PATCH] leds: upboard: fix module alias Thomas Richard
2025-10-16 19:11 ` Krzysztof Kozlowski
2025-10-17 9:00 ` Thomas Richard
2025-10-17 9:03 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=256ccf82-f893-42da-890f-6e4494394cb7@kernel.org \
--to=krzk@kernel.org \
--cc=DanieleCleri@aaeon.eu \
--cc=GaryWang@aaeon.com.tw \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).