From: Milo Kim <woogyom.kim@gmail.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
gregkh@linuxfoundation.org, ming.lei@canonical.com,
daniel.wagner@bmw-carit.de, teg@jklm.no, mchehab@osg.samsung.com,
zajec5@gmail.com, linux-kernel@vger.kernel.org,
markivx@codeaurora.org, stephen.boyd@linaro.org,
broonie@kernel.org, zohar@linux.vnet.ibm.com, tiwai@suse.de,
johannes@sipsolutions.net, chunkeey@googlemail.com,
hauke@hauke-m.de, jwboyer@fedoraproject.org,
dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com,
torvalds@linux-foundation.org, luto@amacapital.net,
fengguang.wu@intel.com, rpurdie@rpsys.net,
Abhay_Salunke@dell.com, Julia.Lawall@lip6.fr,
Gilles.Muller@lip6.fr, nicolas.palix@imag.fr,
dhowells@redhat.com, bjorn.andersson@linaro.org,
arend.vanspriel@broadcom.com, kvalo@codeaurora.org,
linux-leds@vger.k
Subject: Re: [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism
Date: Wed, 14 Dec 2016 10:48:37 +0900 [thread overview]
Message-ID: <271c9d23-d35e-252b-d03b-651457112d28@gmail.com> (raw)
In-Reply-To: <10f8c7f7-a255-4830-65f0-a040d8236bf1@samsung.com>
Hi Jacek,
On 12/13/2016 06:44 PM, Jacek Anaszewski wrote:
>
> Could you please verify if leds-lp55xx-common.c driver
> really needs a custom firmware loading fallback mechanism?
Thanks for sharing this. The lp55xx-common uses this mechanism to load
and run LED effect manually, so this could be a misuse case.
I think the right solution is providing device attributes.
At this moment, four drivers use lp55xx-common code.
- lp5521, lp5523: OK if we do not support FW loading fallback mechanism
- lp5562, lp8501: need to create additional sysfs alternatively.
However, we should be careful because I'm not sure this modification
will generate the regression (breaking the user-space) or not.
Best regards,
Milo
next prev parent reply other threads:[~2016-12-14 1:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161213030828.17820-1-mcgrof@kernel.org>
2016-12-13 3:08 ` [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism Luis R. Rodriguez
2016-12-13 6:13 ` Julia Lawall
2016-12-13 9:44 ` Jacek Anaszewski
2016-12-14 1:48 ` Milo Kim [this message]
2016-12-16 9:29 ` Luis R. Rodriguez
2017-01-11 18:51 ` Luis R. Rodriguez
2016-12-13 3:08 ` [PATCH 5/5] firmware: add DECLARE_FW_CUSTOM_FALLBACK() annotation Luis R. Rodriguez
2016-12-13 19:04 ` Pavel Machek
2016-12-16 9:22 ` Luis R. Rodriguez
2016-12-16 9:29 ` Pavel Machek
2016-12-16 9:59 ` Luis R. Rodriguez
2016-12-16 10:14 ` Pavel Machek
2016-12-16 10:56 ` Luis R. Rodriguez
2016-12-16 11:27 ` Pavel Machek
2016-12-16 15:19 ` Luis R. Rodriguez
2016-12-16 16:10 ` Luis R. Rodriguez
2016-12-16 16:14 ` Luis R. Rodriguez
2016-12-18 3:50 ` Milo Kim
2016-12-19 20:08 ` Pavel Machek
2016-12-19 20:46 ` Jacek Anaszewski
2016-12-21 18:49 ` Pavel Machek
2016-12-21 20:33 ` Jacek Anaszewski
2016-12-15 9:32 ` Jacek Anaszewski
2016-12-16 9:26 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=271c9d23-d35e-252b-d03b-651457112d28@gmail.com \
--to=woogyom.kim@gmail.com \
--cc=Abhay_Salunke@dell.com \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=arend.vanspriel@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=chunkeey@googlemail.com \
--cc=daniel.wagner@bmw-carit.de \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hauke@hauke-m.de \
--cc=j.anaszewski@samsung.com \
--cc=johannes@sipsolutions.net \
--cc=jslaby@suse.com \
--cc=jwboyer@fedoraproject.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.k \
--cc=luto@amacapital.net \
--cc=markivx@codeaurora.org \
--cc=mcgrof@kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=ming.lei@canonical.com \
--cc=nicolas.palix@imag.fr \
--cc=rpurdie@rpsys.net \
--cc=stephen.boyd@linaro.org \
--cc=teg@jklm.no \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=zajec5@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).