Re: [PATCH v2 11/21] ARM: pxa: magician: Add MAX1586 Vcore regulator support

Robert Jarzmik
2015-08-20T19:36:42Z

Petr Cvek <petr.cvek@tul.cz> writes:

> Add support for MAX1586 Vcore regulator.
>
> Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
I'll leave that for a week and if no objections queue it.

I would have expected a better commit message : for example, from your patch I
deduce magician has a 1587 regulator, not a 1586 one : that deserves a small
mention in the commit message. Moreover, the Maxim has 2 outputs : one is
connected to VCC_Core of the SoC, what about the other output ? Is it unknown,
or do you know but don't use it ?

Cheers.

--
Robert