Re: [PATCH v2 06/21] ARM: pxa: magician: Add normal and power I2C definition

Philipp Zabel
2015-08-19T08:02:33Z

Am Montag, den 17.08.2015, 23:59 +0200 schrieb Petr Cvek:
> Add normal and power I2C definition to HTC Magician.

What do you need i2c-gpio for? As I said before, I don't think this
should be in mainline, rather the pxa-i2c driver should be used.

>
> /*
> + * PXA I2C power controller
> + */
> +
> +static struct i2c_pxa_platform_data magician_i2c_power_info = {
> + .fast_mode = 0,
> + .use_pio = 0,
> +};
[...]
> @@ -975,7 +1009,7 @@ static void __init magician_init(void)
> platform_add_devices(ARRAY_AND_SIZE(devices));
>
> pxa_set_ficp_info(&magician_ficp_info);
> - pxa27x_set_i2c_power_info(NULL);
> + pxa27x_set_i2c_power_info(&magician_i2c_power_info);

Does this actually have an effect?

regards
Philipp