From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Ojha Subject: Re: [PATCH] leds: blinkm: clean up double assignment to data->i2c_addr Date: Sun, 31 Mar 2019 12:48:03 +0530 Message-ID: <29b18466-cfd3-e22b-f17f-18f20b048d13@codeaurora.org> References: <20190330203757.8877-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190330203757.8877-1-colin.king@canonical.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Colin King , Jan-Simon Moeller , Jacek Anaszewski , Pavel Machek , linux-leds@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-leds@vger.kernel.org On 3/31/2019 2:07 AM, Colin King wrote: > From: Colin Ian King > > Currently data->i2c_addr is being assigned twice, first with the > value 0x09 and then immediately afterwards with the value 0x08. > The first assignment is redundant and can be removed. > > Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh > --- > drivers/leds/leds-blinkm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c > index 851c1920b63c..11b771fb933b 100644 > --- a/drivers/leds/leds-blinkm.c > +++ b/drivers/leds/leds-blinkm.c > @@ -594,7 +594,6 @@ static int blinkm_probe(struct i2c_client *client, > goto exit; > } > > - data->i2c_addr = 0x09; > data->i2c_addr = 0x08; > /* i2c addr - use fake addr of 0x08 initially (real is 0x09) */ > data->fw_ver = 0xfe;