From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B8ECC001B0 for ; Mon, 24 Jul 2023 10:04:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232855AbjGXKEU (ORCPT ); Mon, 24 Jul 2023 06:04:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233179AbjGXKDF (ORCPT ); Mon, 24 Jul 2023 06:03:05 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D30E6525D for ; Mon, 24 Jul 2023 02:55:36 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-991fe70f21bso669629066b.3 for ; Mon, 24 Jul 2023 02:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690192455; x=1690797255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=94dQO8LxQMdHUG+2c49m7yEu0QyNmeaEeNnaDcdEi50=; b=C6upeyf13JVH1fJWFmxl5BfIVVJfySCtaefw1vI3x426/paosiVxJES5cj2CGWW2KS Cr/m8HDwA0yaKDzQUno8Nq8tigb2vq0EXkwst84ddXYuKmFLmzEaRwboQ6TczmL3wAVv UZ2GE+0c4ocQG69t1izN3t24OytyRFu5kErU9QUsF8Tdc94ZLAwmly6y6rFwbSczEVMy AP4yR1Xe+rvzdZ91EjcwvRQFccLWdWPr2BBk6KNL0+cl4RY1xAUR1S9oB18B8ibq4vKy wZgiFS7XsagNbsm/SvbcS9oHEySLYJJJXxjVOP9bxf4y5oWwItOWI2wLPuYFtIPtowp+ MxKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690192455; x=1690797255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=94dQO8LxQMdHUG+2c49m7yEu0QyNmeaEeNnaDcdEi50=; b=SOj9jxEA4s8yZCoOm5WVniog6y8SI5Bk7T8aTjzYVr2n/UAdgFqpW2XRNwBrTEaH5a mNpUZiS48zW19Do09P8thqV88ybiEekUKPawOgcfLHDXj+ZvzW8FxysuFpYzCdOLOPn/ Bbkv0pySmdz9A1RDKWiXg1Y1zupKYKqhZLS5GQHRdW+tpvJ35S/Y/2zEDmnuESlTDa61 1xyRRh9y3Y+WXRgF6S5Blqdc/sMT7pH7xIuGNSnVSZobdMptAQ/mcILQWcUQWfUcKPZ1 DOndHyMWMqZX0V8JilCmpIHeERPOsd34kJCjPH4O17eMHG9gg3QWBRkVel312ZbuApvE rQXg== X-Gm-Message-State: ABy/qLbObhEl4t8opFbhQI1My6i1nkzWMEIvI5jTetMngHuiu/UfpMY2 bi/bVakyQKUZsyVkZWQlk5Fw3cFHS7T9JB3ze+S5Sg== X-Google-Smtp-Source: APBJJlFaYyJc7x+0ExqkM6W4yVmevNoyHsVyru+pCZlw6jseQKGHeO49Y942+w5FqL1ss44s207a2g== X-Received: by 2002:a17:906:778f:b0:982:45ca:ac06 with SMTP id s15-20020a170906778f00b0098245caac06mr8953749ejm.60.1690192455496; Mon, 24 Jul 2023 02:54:15 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id e13-20020a170906248d00b0099307a5c564sm6473655ejb.55.2023.07.24.02.54.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 02:54:15 -0700 (PDT) Message-ID: <29b62cc6-bc54-9a43-211b-b2d7579218b7@linaro.org> Date: Mon, 24 Jul 2023 11:54:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO Content-Language: en-US To: Alexander Stein , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Pavel Machek , Lee Jones Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20230724063520.182888-1-alexander.stein@ew.tq-group.com> <0f016242-2380-274e-c6a4-118a5872412e@linaro.org> <21957396.EfDdHjke4D@steina-w> From: Krzysztof Kozlowski In-Reply-To: <21957396.EfDdHjke4D@steina-w> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 24/07/2023 09:58, Alexander Stein wrote: > Hi, > > Am Montag, 24. Juli 2023, 09:23:09 CEST schrieb Krzysztof Kozlowski: >> On 24/07/2023 08:35, Alexander Stein wrote: >>> This is a gpio-controller, so gpio-line-names should be allowed as well. >>> stmpe2403 supports up to 24 GPIOs. >>> >>> Signed-off-by: Alexander Stein >>> --- >>> Changes in v2: >>> * Add min/maxItems >>> >>> Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml >>> b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml index >>> 22c0cae73425..4555f1644a4d 100644 >>> --- a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml >>> +++ b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml >>> >>> @@ -28,6 +28,10 @@ properties: >>> gpio-controller: true >>> >>> + gpio-line-names: >>> + minItems: 1 >>> + maxItems: 24 >>> + >> >> I am sure there is no variant with one GPIO. > > That's true. But if only one GPIO is actually connected there is no use > enforcing to add empty entries. > AFAIK it is also allowed to provide an incomplete array. Did you test it? Linux prints warning. Warning means "not allowed". The expectation is that the rest are named "NC". Best regards, Krzysztof