From: Markus Elfring <Markus.Elfring@web.de>
To: Nam Tran <trannamatk@gmail.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
Date: Tue, 25 Mar 2025 20:15:31 +0100 [thread overview]
Message-ID: <2bfc3077-7ef4-45bc-b747-caf0a701f987@web.de> (raw)
In-Reply-To: <20250306172126.24667-4-trannamatk@gmail.com>
…
> +++ b/drivers/leds/leds-lp5812.c
> @@ -0,0 +1,2190 @@
…
> +static ssize_t device_enable_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{
…
> + mutex_lock(&chip->lock);
> + if (lp5812_read(chip, chip->regs->enable_reg, &enable)) {
> + mutex_unlock(&chip->lock);
> + return -EIO;
> + }
> + mutex_unlock(&chip->lock);
> +
> + return sprintf(buf, "%d\n", enable);
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&chip->lock);”?
https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/mutex.h#L201
Regards,
Markus
next prev parent reply other threads:[~2025-03-25 19:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 17:21 [PATCH v3 0/3] leds: add new LED driver for TI LP5812 Nam Tran
2025-03-06 17:21 ` [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver Nam Tran
2025-03-07 8:42 ` Krzysztof Kozlowski
2025-03-18 13:56 ` Nam Tran
2025-03-18 18:59 ` Krzysztof Kozlowski
2025-03-31 15:31 ` Nam Tran
2025-03-31 15:42 ` Krzysztof Kozlowski
2025-04-01 14:29 ` Nam Tran
2025-04-01 15:04 ` Krzysztof Kozlowski
2025-03-06 17:21 ` [PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B Nam Tran
2025-03-07 8:42 ` Krzysztof Kozlowski
2025-03-07 8:43 ` Krzysztof Kozlowski
2025-03-06 17:21 ` [PATCH v3 3/3] leds: add new LED driver for TI LP5812 Nam Tran
2025-03-06 18:53 ` Christophe JAILLET
2025-03-07 8:52 ` Krzysztof Kozlowski
2025-03-24 4:44 ` Nam Tran
2025-03-10 1:21 ` kernel test robot
2025-03-11 11:20 ` kernel test robot
2025-03-18 13:35 ` Nam Tran
2025-03-18 18:54 ` Krzysztof Kozlowski
2025-03-24 4:39 ` Nam Tran
2025-03-20 15:50 ` Lee Jones
2025-03-24 4:34 ` Nam Tran
2025-03-25 19:15 ` Markus Elfring [this message]
2025-03-27 15:48 ` Nam Tran
[not found] <0250320155012.GT3890718@google.com>
2025-03-24 3:54 ` Nam Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bfc3077-7ef4-45bc-b747-caf0a701f987@web.de \
--to=markus.elfring@web.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=trannamatk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox