From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D41EC6FD1C for ; Wed, 22 Mar 2023 17:21:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229717AbjCVRVV (ORCPT ); Wed, 22 Mar 2023 13:21:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229672AbjCVRVU (ORCPT ); Wed, 22 Mar 2023 13:21:20 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFD274DE0F for ; Wed, 22 Mar 2023 10:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679505592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZfrH3cNmdRz+kg65KNKYqXw3b322J99Rm/Jrfqmb5q4=; b=c1jzBhzqqLEDI2UG57xj7+aIvGQtRQqB81VztSfd414ktWNTp0onDYtZ3rAVJ5jIvmBaF5 45tEPSrhQuMKfCc90QC44flHzWkRoeKIw+9+dmOpvOz0Zd9WDR0F0nKHn4TIJxA03ty+07 dxQ7N9Md1qqdd6w0I3cB6HL7Hy9UYfU= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-413-CcEgH9OuMYWOXa4K8ueWHw-1; Wed, 22 Mar 2023 13:19:51 -0400 X-MC-Unique: CcEgH9OuMYWOXa4K8ueWHw-1 Received: by mail-ed1-f69.google.com with SMTP id h11-20020a0564020e8b00b004e59d4722a3so27971261eda.6 for ; Wed, 22 Mar 2023 10:19:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679505590; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZfrH3cNmdRz+kg65KNKYqXw3b322J99Rm/Jrfqmb5q4=; b=l2JAz3DJkltb/zd5S/7TTazvwSSuvScSl95S8uJUZ2B7SgW+uwB6z5YF4M4diaUwhr QOKW/bgjJqqfKPBy93pto6g0riNuR6nzdVjDuLQdv8a5cCE/Z4RAF7ibYIohSpJs/a6E PQOnaFUCvMqgGGAT5L2ZTHzhYBS6co1baXF8HueBlgCgnnHFU42UNpKbb4Frc9y8OJOI YCpbKO95d1WNS2hMTxU/nFSJyF2Y/jlZe36KYoV2DrY9mNz/0tPgHf/vaW/LPAVYx9oh eKvM1Y8fMFn3UuGjo4GQMd6TT9On1ITNIc/PT9Gt7smHtkjfJVJZhcZLVLTjh2befdab zUcg== X-Gm-Message-State: AO0yUKXX/VNrd6JSbwa0t2DZBdl0DtZIKX/lp+8MoacuXYb709BybPiL xoYxsM73aQ+2NpI9dCnkKftgOGAUQUeVQgw+sXug0NgvYNLDHIXxfpjo9o4kP2F/31K0CN5Weoh yF/4I9OIfKm+n6A+bE88emg== X-Received: by 2002:a17:906:7102:b0:8b1:806b:7dbb with SMTP id x2-20020a170906710200b008b1806b7dbbmr8030492ejj.51.1679505590247; Wed, 22 Mar 2023 10:19:50 -0700 (PDT) X-Google-Smtp-Source: AK7set9roFBaPaz/PzuSkkNGs01P2Z5DlAbHosKfcq2HEBjcjboJI19NhHqXk4vpRzjAendoTOabbg== X-Received: by 2002:a17:906:7102:b0:8b1:806b:7dbb with SMTP id x2-20020a170906710200b008b1806b7dbbmr8030469ejj.51.1679505589936; Wed, 22 Mar 2023 10:19:49 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id g3-20020a50d5c3000000b004fb17f10326sm8090663edj.10.2023.03.22.10.19.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 10:19:49 -0700 (PDT) Message-ID: <2d7d8ed7-0511-b30e-71a8-35f1cc76397e@redhat.com> Date: Wed, 22 Mar 2023 18:19:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 4/8] platform/x86: int3472: Add tps68470-led as clock consumer Content-Language: en-US, nl To: Daniel Scally , linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: pavel@ucw.cz, lee@kernel.org, markgross@kernel.org, sboyd@kernel.org, hpa@redhat.com References: <20230322160926.948687-1-dan.scally@ideasonboard.com> <20230322160926.948687-5-dan.scally@ideasonboard.com> From: Hans de Goede In-Reply-To: <20230322160926.948687-5-dan.scally@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi, On 3/22/23 17:09, Daniel Scally wrote: > Some of the LEDs provided by the TPS68470 require the clock that it > provides to be active in order to function. Add the platform driver > for the leds as a consumer of the clock so that the led driver can > discover it during .probe() > > Signed-off-by: Daniel Scally > --- > drivers/platform/x86/intel/int3472/tps68470.c | 21 ++++++++++++------- > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/drivers/platform/x86/intel/int3472/tps68470.c b/drivers/platform/x86/intel/int3472/tps68470.c > index 53b0459f278a..818f2fc5bf2a 100644 > --- a/drivers/platform/x86/intel/int3472/tps68470.c > +++ b/drivers/platform/x86/intel/int3472/tps68470.c > @@ -105,25 +105,30 @@ skl_int3472_fill_clk_pdata(struct device *dev, struct tps68470_clk_platform_data > { > struct acpi_device *adev = ACPI_COMPANION(dev); > struct acpi_device *consumer; > - unsigned int n_consumers = 0; > + unsigned int n_consumers = 1; > const char *sensor_name; > - unsigned int i = 0; > + const char *led_name; > + unsigned int i = 1; Nitpick: please just don't init i here at all. > > for_each_acpi_consumer_dev(adev, consumer) > n_consumers++; > > - if (!n_consumers) { > - dev_err(dev, "INT3472 seems to have no dependents\n"); > - return -ENODEV; > - } > - > *clk_pdata = devm_kzalloc(dev, struct_size(*clk_pdata, consumers, n_consumers), > GFP_KERNEL); > if (!*clk_pdata) > return -ENOMEM; > > (*clk_pdata)->n_consumers = n_consumers; > - i = 0; > + > + /* > + * The TPS68470 includes an LED driver which requires the clock be active > + * to function. Add the led platform device as a consumer of the clock. > + */ > + led_name = devm_kstrdup(dev, "tps68470-led", GFP_KERNEL); > + if (!led_name) > + return -ENOMEM; > + > + (*clk_pdata)->consumers[0].consumer_dev_name = led_name; > And add a: i = 1; here, to make it clear that after setting consumers[0] we now start adding more consumers at index 1. > for_each_acpi_consumer_dev(adev, consumer) { > sensor_name = devm_kasprintf(dev, GFP_KERNEL, I2C_DEV_NAME_FORMAT, With that fixed: Reviewed-by: Hans de Goede Regards, Hans